RESOLVED FIXED 174836
bisect-builds: add --list option 
https://bugs.webkit.org/show_bug.cgi?id=174836
Summary bisect-builds: add --list option
Lucas Forschler
Reported 2017-07-25 14:25:56 PDT
We should add a --list option to get a list of revisions. We should also print out a list of platform and configurations.
Attachments
v1 patch for review (2.43 KB, patch)
2017-09-08 16:43 PDT, Lucas Forschler 		lforschler: commit-queue-
DetailsFormatted DiffDiff
v2 patch from feedback (2.43 KB, patch)
2017-09-08 17:57 PDT, Lucas Forschler 		lforschler: commit-queue-
DetailsFormatted DiffDiff
v3. (3.35 KB, patch)
2017-09-08 22:20 PDT, Lucas Forschler 		lforschler: commit-queue-
DetailsFormatted DiffDiff
v3 (3.35 KB, patch)
2017-09-08 22:21 PDT, Lucas Forschler 		slewis: review+
lforschler: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-25 14:26:43 PDT
<rdar://problem/33521944>
Lucas Forschler
Comment 2 2017-09-08 16:43:41 PDT
Created attachment 320315 [details] v1 patch for review
Sam Weinig
Comment 3 2017-09-08 17:46:17 PDT
Comment on attachment 320315 [details] v1 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=320315&action=review > Tools/Scripts/bisect-builds:225 > + print 'Supported minified platforms: {}'.format(minified_platforms()) > + print 'Supported unminified platforms: {}'.format(unminified_platforms()) What does minified/unminified mean in this context?
Lucas Forschler
Comment 4 2017-09-08 17:52:26 PDT
Comment on attachment 320315 [details] v1 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=320315&action=review >> Tools/Scripts/bisect-builds:225 >> + print 'Supported unminified platforms: {}'.format(unminified_platforms()) > > What does minified/unminified mean in this context? Minified archives are those with dSYMs and a few other non-essential bits stripped out. They are approximately 90% smaller than full archives (unminified) We keep full archives for 14 days. Minified Archives for 2.5 years.
Lucas Forschler
Comment 5 2017-09-08 17:57:08 PDT
Created attachment 320322 [details] v2 patch from feedback
Konstantin Tokarev
Comment 6 2017-09-08 18:15:01 PDT
Comment on attachment 320322 [details] v2 patch from feedback View in context: https://bugs.webkit.org/attachment.cgi?id=320322&action=review > Tools/Scripts/bisect-builds:228 > + exit(1) I think it should be exit(0), as it is not exit because of error
Sam Weinig
Comment 7 2017-09-08 20:07:28 PDT
Does the help text document the minified term anywhere? If not, I think it probably needs to say something clearer, or explain what that means in some way.
Lucas Forschler
Comment 8 2017-09-08 21:49:41 PDT
Comment on attachment 320322 [details] v2 patch from feedback View in context: https://bugs.webkit.org/attachment.cgi?id=320322&action=review >> Tools/Scripts/bisect-builds:228 >> + exit(1) > > I think it should be exit(0), as it is not exit because of error good catch, will fix.
Lucas Forschler
Comment 9 2017-09-08 21:53:04 PDT
(In reply to Sam Weinig from comment #7) > Does the help text document the minified term anywhere? If not, I think it > probably needs to say something clearer, or explain what that means in some > way. I will investigate working this into the help text.
Lucas Forschler
Comment 10 2017-09-08 22:20:23 PDT
Created attachment 320333 [details] v3.
Lucas Forschler
Comment 11 2017-09-08 22:21:44 PDT
Created attachment 320334 [details] v3
Aakash Jain
Comment 12 2017-09-11 16:48:39 PDT
Comment on attachment 320334 [details] v3 View in context: https://bugs.webkit.org/attachment.cgi?id=320334&action=review > Tools/Scripts/bisect-builds:225 > + print('Supported minified platforms: {}'.format(minified_platforms())) It might be a good idea to make this a function, instead of having all these print statements in main.
Lucas Forschler
Comment 13 2017-09-11 17:10:32 PDT
Committed revision 221895.
Note You need to log in before you can comment on or make changes to this bug.