Bug 174836 - bisect-builds: add --list option
Summary: bisect-builds: add --list option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on: 174596
Blocks:
  Show dependency tree / graph
 
Reported: 2017-07-25 14:25 PDT by Lucas Forschler
Modified: 2018-01-15 12:51 PST (History)
7 users (show)

See Also:

Attachments
v1 patch for review (2.43 KB, patch)
2017-09-08 16:43 PDT, Lucas Forschler 		lforschler: commit-queue-
Details | Formatted Diff | Diff
v2 patch from feedback (2.43 KB, patch)
2017-09-08 17:57 PDT, Lucas Forschler 		lforschler: commit-queue-
Details | Formatted Diff | Diff
v3. (3.35 KB, patch)
2017-09-08 22:20 PDT, Lucas Forschler 		lforschler: commit-queue-
Details | Formatted Diff | Diff
v3 (3.35 KB, patch)
2017-09-08 22:21 PDT, Lucas Forschler 		slewis: review+
lforschler: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-07-25 14:25:56 PDT 
We should add a --list option to get a list of revisions.
We should also print out a list of platform and configurations.
Comment 1 Radar WebKit Bug Importer 2017-07-25 14:26:43 PDT 
<rdar://problem/33521944>
Comment 2 Lucas Forschler 2017-09-08 16:43:41 PDT 
Created attachment 320315 [details]
v1 patch for review
Comment 3 Sam Weinig 2017-09-08 17:46:17 PDT 
Comment on attachment 320315 [details]
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=320315&action=review

> Tools/Scripts/bisect-builds:225
> +        print 'Supported minified platforms: {}'.format(minified_platforms())
> +        print 'Supported unminified platforms: {}'.format(unminified_platforms())

What does minified/unminified mean in this context?
Comment 4 Lucas Forschler 2017-09-08 17:52:26 PDT 
Comment on attachment 320315 [details]
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=320315&action=review

>> Tools/Scripts/bisect-builds:225
>> +        print 'Supported unminified platforms: {}'.format(unminified_platforms())
> 
> What does minified/unminified mean in this context?

Minified archives are those with dSYMs and a few other non-essential bits stripped out. They are approximately 90% smaller than full archives (unminified)
We keep full archives for 14 days. Minified Archives for 2.5 years.
Comment 5 Lucas Forschler 2017-09-08 17:57:08 PDT 
Created attachment 320322 [details]
v2 patch from feedback
Comment 6 Konstantin Tokarev 2017-09-08 18:15:01 PDT 
Comment on attachment 320322 [details]
v2 patch from feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=320322&action=review

> Tools/Scripts/bisect-builds:228
> +        exit(1)

I think it should be exit(0), as it is not exit because of error
Comment 7 Sam Weinig 2017-09-08 20:07:28 PDT 
Does the help text document the minified term anywhere? If not, I think it probably needs to say something clearer, or explain what that means in some way.
Comment 8 Lucas Forschler 2017-09-08 21:49:41 PDT 
Comment on attachment 320322 [details]
v2 patch from feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=320322&action=review

>> Tools/Scripts/bisect-builds:228
>> +        exit(1)
> 
> I think it should be exit(0), as it is not exit because of error

good catch, will fix.
Comment 9 Lucas Forschler 2017-09-08 21:53:04 PDT 
(In reply to Sam Weinig from comment #7)
> Does the help text document the minified term anywhere? If not, I think it
> probably needs to say something clearer, or explain what that means in some
> way.

I will investigate working this into the help text.
Comment 10 Lucas Forschler 2017-09-08 22:20:23 PDT 
Created attachment 320333 [details]
v3.
Comment 11 Lucas Forschler 2017-09-08 22:21:44 PDT 
Created attachment 320334 [details]
v3
Comment 12 Aakash Jain 2017-09-11 16:48:39 PDT 
Comment on attachment 320334 [details]
v3

View in context: https://bugs.webkit.org/attachment.cgi?id=320334&action=review

> Tools/Scripts/bisect-builds:225
> +        print('Supported minified platforms: {}'.format(minified_platforms()))

It might be a good idea to make this a function, instead of having all these print statements in main.
Comment 13 Lucas Forschler 2017-09-11 17:10:32 PDT 
Committed revision 221895.