Dragged links are blurry on 1x displays.

[Per Arne Vollan]

When I drag a link from a 2x display to a 1x display, the text in the drag image is blurry.

[Per Arne Vollan]

<rdar://problem/33519698>

[Per Arne Vollan]

Created attachment 316388 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 316388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316388&action=review

> Source/WebCore/platform/mac/DragImageMac.mm:293
> +    // To work around blurry drag images on 1x displays, make the width and height a multiple of 2.
> +    // FIXME: remove this workaround when <rdar://problem/33059739> is fixed.
> +    boundingRect.setWidth((static_cast<int>(boundingRect.width()) / 2) * 2);
> +    boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2));

Is this a user-visible change, or does it just add transparent pixels? Does it affect alignment of the image with the pointer?

[Per Arne Vollan]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 316388 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316388&action=review
> 
> > Source/WebCore/platform/mac/DragImageMac.mm:293
> > +    // To work around blurry drag images on 1x displays, make the width and height a multiple of 2.
> > +    // FIXME: remove this workaround when <rdar://problem/33059739> is fixed.
> > +    boundingRect.setWidth((static_cast<int>(boundingRect.width()) / 2) * 2);
> > +    boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2));
> 
> Is this a user-visible change, or does it just add transparent pixels? Does
> it affect alignment of the image with the pointer?

Do you mean if this changes the alignment of the memory address of the image data?

Thanks for reviewing!

[Simon Fraser (smfr)]

Comment on attachment 316388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316388&action=review

>>> Source/WebCore/platform/mac/DragImageMac.mm:293
>>> +    boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2));
>> 
>> Is this a user-visible change, or does it just add transparent pixels? Does it affect alignment of the image with the pointer?
> 
> Do you mean if this changes the alignment of the memory address of the image data?
> 
> Thanks for reviewing!

No, i mean the position of the drag image relative to the mouse pointer.

[Per Arne Vollan]

(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 316388 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316388&action=review
> 
> >>> Source/WebCore/platform/mac/DragImageMac.mm:293
> >>> +    boundingRect.setHeight((static_cast<int>(boundingRect.height() / 2) * 2));
> >> 
> >> Is this a user-visible change, or does it just add transparent pixels? Does it affect alignment of the image with the pointer?
> > 
> > Do you mean if this changes the alignment of the memory address of the image data?
> > 
> > Thanks for reviewing!
> 
> No, i mean the position of the drag image relative to the mouse pointer.

Ah, yes, I believe it does affect the alignment with the pointer, since the image size is used in this calculation.

[Simon Fraser (smfr)]

That's bad, then.

[Per Arne Vollan]

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 316388 [details]
Patch

Clearing flags on attachment: 316388

Committed r219891: <http://trac.webkit.org/changeset/219891>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.