Bug 174815 – [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to use WebKit dir, while the tests are still in WebKit2 directory.

[Carlos Garcia Campos]

Created attachment 316362 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 316362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316362&action=review

> Tools/ChangeLog:10
> +        ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
> +        use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes

I think the patch is fine for fixing this issue now,

But I suggest to clarify on the bug of the rename if not applying the webkit2->webkit and webkit->webkitlegacy renaming also on the directories Tools/TestWebKitAPI/Tests was intentional or an overlook.

[Carlos Garcia Campos]

Committed r219865: <http://trac.webkit.org/changeset/219865>

[Michael Catanzaro]

Of course it's an oversight, we have to rename all the directories.

[Darin Adler]

(In reply to Michael Catanzaro from comment #4)
> Of course it's an oversight, we have to rename all the directories.

Agreed.