Bug 174815 - [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
Summary: [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2017-07-25 04:08 PDT by Carlos Garcia Campos
Modified: 2017-07-25 09:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (14.62 KB, patch)
2017-07-25 04:11 PDT, Carlos Garcia Campos
clopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-07-25 04:08:13 PDT
Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to use WebKit dir, while the tests are still in WebKit2 directory.
Comment 1 Carlos Garcia Campos 2017-07-25 04:11:38 PDT
Created attachment 316362 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-07-25 04:23:06 PDT
Comment on attachment 316362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316362&action=review

> Tools/ChangeLog:10
> +        ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
> +        use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes

I think the patch is fine for fixing this issue now,

But I suggest to clarify on the bug of the rename if not applying the webkit2->webkit and webkit->webkitlegacy renaming also on the directories Tools/TestWebKitAPI/Tests was intentional or an overlook.
Comment 3 Carlos Garcia Campos 2017-07-25 04:36:58 PDT
Committed r219865: <http://trac.webkit.org/changeset/219865>
Comment 4 Michael Catanzaro 2017-07-25 07:06:41 PDT
Of course it's an oversight, we have to rename all the directories.
Comment 5 Darin Adler 2017-07-25 09:09:08 PDT
(In reply to Michael Catanzaro from comment #4)
> Of course it's an oversight, we have to rename all the directories.

Agreed.