Bug 174803 – Web Automation: files selected for upload should be checked against values of the 'accept' attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Blaze Burg]

placeholder text.

[Radar WebKit Bug Importer]

<rdar://problem/33514190>

[Blaze Burg]

Created attachment 316913 [details]
Proposed Fix

[Blaze Burg]

Created attachment 316914 [details]
Proposed Fix

[Carlos Garcia Campos]

Comment on attachment 316914 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316914&action=review

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:559
> +        if (!allowedMIMETypes.size())
> +            continue;

Nit: I usually prefer isEmpty()

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:579
> +            filesAreValid = false;
> +            break;

I think this would be easier if we moved this loop into a function, then you could just return false instead of filesAreValid = false + break;

[Build Bot]

Comment on attachment 316914 [details]
Proposed Fix

Attachment 316914 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4240379

New failing tests:
fast/dom/StyleSheet/detached-sheet-owner-node-link.html

[Build Bot]

Created attachment 316968 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Blaze Burg]

Committed r220147: <http://trac.webkit.org/changeset/220147>