Bug 174791 - [GTK][WPE] Stop using AutodrainedPool in IconDatabase
Summary: [GTK][WPE] Stop using AutodrainedPool in IconDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-24 09:23 PDT by Michael Catanzaro
Modified: 2017-07-24 11:55 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.27 KB, patch)
2017-07-24 09:25 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-07-24 09:23:15 PDT 
AutodrainedPool seems to be some NS garbage collection thing that has no implementation on other platforms. Now that IconDatabase is used only by GTK and WPE, we can stop using it.
Comment 1 Michael Catanzaro 2017-07-24 09:25:15 PDT 
Created attachment 316296 [details]
Patch
Comment 2 Build Bot 2017-07-24 09:27:06 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2017-07-24 11:55:32 PDT 
Comment on attachment 316296 [details]
Patch

Clearing flags on attachment: 316296

Committed r219832: <http://trac.webkit.org/changeset/219832>
Comment 4 WebKit Commit Bot 2017-07-24 11:55:34 PDT 
All reviewed patches have been landed.  Closing bug.