Bug 174783 - WebDriver: rename m_browsingContext as m_currentBrowsingContext in Session
Summary: WebDriver: rename m_browsingContext as m_currentBrowsingContext in Session
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-24 03:41 PDT by Carlos Garcia Campos
Modified: 2017-07-24 12:17 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.82 KB, patch)
2017-07-24 03:43 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (982.35 KB, application/zip)
2017-07-24 07:15 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-07-24 03:41:41 PDT 
We have m_toplevelBrowsingContext and m_browsingContext, which is confusing.  m_browsingContext is actually the current browsing context, and the spec also uses current, so better use m_currentBrowsingContext.
Comment 1 Carlos Garcia Campos 2017-07-24 03:43:44 PDT 
Created attachment 316279 [details]
Patch
Comment 2 Build Bot 2017-07-24 07:15:29 PDT 
Comment on attachment 316279 [details]
Patch

Attachment 316279 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4178546

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Comment 3 Build Bot 2017-07-24 07:15:30 PDT 
Created attachment 316289 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 BJ Burg 2017-07-24 11:48:15 PDT 
Comment on attachment 316279 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2017-07-24 12:16:59 PDT 
Comment on attachment 316279 [details]
Patch

Clearing flags on attachment: 316279

Committed r219833: <http://trac.webkit.org/changeset/219833>
Comment 6 WebKit Commit Bot 2017-07-24 12:17:00 PDT 
All reviewed patches have been landed.  Closing bug.