Bug 174765 - Web Inspector: should only show Canvases in resource type filter if debug setting enabled
Summary: Web Inspector: should only show Canvases in resource type filter if debug set...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-23 16:50 PDT by Matt Baker
Modified: 2017-07-24 10:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2017-07-23 16:52 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-07-23 16:50:28 PDT 
Summary:
Should only show Canvases in resource type filter if debug setting enabled.

It's very surprising when the option appears in a release build, for which this setting will never be enabled.
Comment 1 Radar WebKit Bug Importer 2017-07-23 16:50:46 PDT 
<rdar://problem/33479009>
Comment 2 Matt Baker 2017-07-23 16:52:54 PDT 
Created attachment 316243 [details]
Patch
Comment 3 Devin Rousso 2017-07-23 23:20:39 PDT 
Comment on attachment 316243 [details]
Patch

Oops.  Good catch =D
Comment 4 BJ Burg 2017-07-24 09:44:44 PDT 
Comment on attachment 316243 [details]
Patch

r=me too
Comment 5 WebKit Commit Bot 2017-07-24 10:13:30 PDT 
Comment on attachment 316243 [details]
Patch

Clearing flags on attachment: 316243

Committed r219826: <http://trac.webkit.org/changeset/219826>
Comment 6 WebKit Commit Bot 2017-07-24 10:13:32 PDT 
All reviewed patches have been landed.  Closing bug.