Bug 174758 – [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

_WKDraggableElementInfo is no longer used anywhere in WebKit, so it should be removed. However, some edge cases in PositionInformationTests that currently use _WKDraggableElementInfo are still useful tests to keep around, so fold them into the WKRequestActivatedElementInfo test suite.

[Wenson Hsieh]

Created attachment 316222 [details]
Patch

Comment on attachment 316222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316222&action=review

> Tools/TestWebKitAPI/cocoa/TestWKWebView.h:56
> +- (_WKActivatedElementInfo *)_activatedElementAtPosition:(CGPoint)position;

Probably don’t need the underscore prefix on this method’s name. It’s like the rest of the TestWKWebView methods.

[Wenson Hsieh]

(In reply to mitz from comment #2)
> Comment on attachment 316222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316222&action=review
> 
> > Tools/TestWebKitAPI/cocoa/TestWKWebView.h:56
> > +- (_WKActivatedElementInfo *)_activatedElementAtPosition:(CGPoint)position;
> 
> Probably don’t need the underscore prefix on this method’s name. It’s like
> the rest of the TestWKWebView methods.

Good catch -- fixed. I originally had it as SPI on WKWebView, and then decided to move it into TestWebKitAPI but didn't rename it.

Thanks for the review!

[Wenson Hsieh]

Created attachment 316224 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 316224 [details]
Patch for landing

Clearing flags on attachment: 316224

Committed r219768: <http://trac.webkit.org/changeset/219768>