Bug 174755 - Merge ExceptionBase into DOMException and drop custom toString
Summary: Merge ExceptionBase into DOMException and drop custom toString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 174677 174743
Blocks:
  Show dependency tree / graph
 
Reported: 2017-07-22 10:06 PDT by Chris Dumez
Modified: 2017-07-25 13:56 PDT (History)
7 users (show)

See Also:

Attachments
Patch (66.00 KB, patch)
2017-07-22 10:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1006.87 KB, application/zip)
2017-07-22 11:10 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.79 MB, application/zip)
2017-07-22 11:35 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.36 MB, application/zip)
2017-07-22 11:37 PDT, Build Bot 		no flags Details
Patch (79.40 KB, patch)
2017-07-22 11:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-22 10:06:09 PDT 
Merge ExceptionBase into DOMException and drop custom toString, now that DOMException is the only remaining exception type.
Comment 1 Chris Dumez 2017-07-22 10:11:34 PDT 
Created attachment 316198 [details]
Patch
Comment 2 Build Bot 2017-07-22 11:10:48 PDT 
Comment on attachment 316198 [details]
Patch

Attachment 316198 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4168507

New failing tests:
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
Comment 3 Build Bot 2017-07-22 11:10:49 PDT 
Created attachment 316202 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-07-22 11:35:00 PDT 
Comment on attachment 316198 [details]
Patch

Attachment 316198 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4168539

New failing tests:
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
Comment 5 Build Bot 2017-07-22 11:35:01 PDT 
Created attachment 316203 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-07-22 11:37:17 PDT 
Comment on attachment 316198 [details]
Patch

Attachment 316198 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4168609

New failing tests:
fast/dynamic/015.html
editing/selection/caret-ltr-2-left.html
editing/selection/caret-rtl.html
fast/attachment/attachment-select-on-click.html
editing/selection/caret-ltr.html
editing/selection/caret-ltr-2.html
editing/selection/caret-ltr-right.html
editing/selection/caret-rtl-2.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html
Comment 7 Build Bot 2017-07-22 11:37:18 PDT 
Created attachment 316204 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 8 Chris Dumez 2017-07-22 11:45:49 PDT 
Created attachment 316205 [details]
Patch
Comment 9 Chris Dumez 2017-07-22 14:20:30 PDT 
Comment on attachment 316205 [details]
Patch

Clearing flags on attachment: 316205

Committed r219766: <http://trac.webkit.org/changeset/219766>
Comment 10 Chris Dumez 2017-07-22 14:20:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Matt Lewis 2017-07-25 13:56:06 PDT 
Added an additional rebaseline for http/tests/quicklook/top-navigation-blocked.html
https://trac.webkit.org/changeset/219884/webkit