There is no reason to let an error encountered when trying to detect a running simulator prevent test expectation linting or style checking. We should ignore such an exception until setting up iOS simulators for testing.
Created attachment 316120 [details] Patch
<rdar://problem/33446618> tracks this internally.
Comment on attachment 316120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316120&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:82 > + IOSSimulatorPort._CURRENT_DEVICE = Device(Simulator(host).current_device()) what's the exception? If Simulator(host).current_device() is None, then it might be better to check for it being non None, instead of try except.
(In reply to Aakash Jain from comment #3) > Comment on attachment 316120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316120&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:82 > > + IOSSimulatorPort._CURRENT_DEVICE = Device(Simulator(host).current_device()) > > what's the exception? > > If Simulator(host).current_device() is None, then it might be better to > check for it being non None, instead of try except. We had an engineer with a unique personal configuration hit this, 'xcrun simctl' commands would fail, so Simulator(host) would throw a webkitpy.common.system.executive.ScriptError. If he were running tests on the Simulator, I'd say we let the exception be thrown, but this code is triggered during style checking and test expectation linting.
Comment on attachment 316120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316120&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:83 > + except: ok. we should use "except ScriptError:"
Created attachment 316125 [details] Patch for landing
Comment on attachment 316125 [details] Patch for landing Clearing flags on attachment: 316125 Committed r219747: <http://trac.webkit.org/changeset/219747>
All reviewed patches have been landed. Closing bug.