Bug 174723 - [iOS] Adopt UIImagePickerControllerImageURL for photo uploads
Summary: [iOS] Adopt UIImagePickerControllerImageURL for photo uploads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-21 12:41 PDT by Andy Estes
Modified: 2017-07-21 15:44 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2017-07-21 12:50 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (12.05 KB, patch)
2017-07-21 14:01 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (11.28 KB, patch)
2017-07-21 14:11 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-07-21 12:41:45 PDT 
[iOS] Adopt UIImagePickerControllerImageURL for photo uploads
Comment 1 Andy Estes 2017-07-21 12:44:54 PDT 
rdar://problem/33223962
Comment 2 Andy Estes 2017-07-21 12:50:35 PDT 
Created attachment 316114 [details]
Patch
Comment 3 Andy Estes 2017-07-21 14:01:09 PDT 
Created attachment 316117 [details]
Patch
Comment 4 Andy Estes 2017-07-21 14:11:52 PDT 
Created attachment 316119 [details]
Patch
Comment 5 Joseph Pecoraro 2017-07-21 14:15:43 PDT 
Comment on attachment 316119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316119&action=review

This looks good to me (r=me)! You'll still need WebKit2 owner's approval (if you are not an owner, maybe you are!)

> Source/WebKit/ChangeLog:11
> +        UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting

Where is this `UIImagePickerControllerImageURLExportPresetCompatible` specified by us? Or is it the default?
Comment 6 Andy Estes 2017-07-21 14:17:07 PDT 
(In reply to Joseph Pecoraro from comment #5)
> Comment on attachment 316119 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316119&action=review
> 
> This looks good to me (r=me)! You'll still need WebKit2 owner's approval (if
> you are not an owner, maybe you are!)
> 
> > Source/WebKit/ChangeLog:11
> > +        UIImagePickerControllerImageURLExportPresetCompatible, UIKit will take care of converting
> 
> Where is this `UIImagePickerControllerImageURLExportPresetCompatible`
> specified by us? Or is it the default?

It's the default.

Thanks for the review!
Comment 7 WebKit Commit Bot 2017-07-21 15:44:35 PDT 
Comment on attachment 316119 [details]
Patch

Clearing flags on attachment: 316119

Committed r219750: <http://trac.webkit.org/changeset/219750>
Comment 8 WebKit Commit Bot 2017-07-21 15:44:37 PDT 
All reviewed patches have been landed.  Closing bug.