RESOLVED FIXED 174722
AX: Expose form validation on iOS as hint 
https://bugs.webkit.org/show_bug.cgi?id=174722
Summary AX: Expose form validation on iOS as hint
Nan Wang
Reported 2017-07-21 12:22:33 PDT
Expose form validation on iOS as hint
Attachments
patch (9.03 KB, patch)
2017-07-21 12:31 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (8.20 KB, patch)
2017-07-21 15:37 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-07-21 12:23:43 PDT
<rdar://problem/33459761>
Nan Wang
Comment 2 2017-07-21 12:31:08 PDT
Created attachment 316110 [details] patch
chris fleizach
Comment 3 2017-07-21 12:47:08 PDT
Comment on attachment 316110 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=316110&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1590 > + if (is<HTMLFormControlElement>(m_renderer->node())) you should be able to just call node() here > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1597 > + if (is<HTMLFormControlElement>(m_renderer->node())) ditto then you can probably just put this in AccessibilityObject so it doesn't have to be virtual
Nan Wang
Comment 4 2017-07-21 15:37:04 PDT
Created attachment 316129 [details] patch update from review
chris fleizach
Comment 5 2017-07-21 15:53:11 PDT
Comment on attachment 316129 [details] patch looks good, wait for bot status = green
WebKit Commit Bot
Comment 6 2017-07-21 16:25:25 PDT
Comment on attachment 316129 [details] patch Clearing flags on attachment: 316129 Committed r219751: <http://trac.webkit.org/changeset/219751>
WebKit Commit Bot
Comment 7 2017-07-21 16:25:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.