Bug 174722 - AX: Expose form validation on iOS as hint
Summary: AX: Expose form validation on iOS as hint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-21 12:22 PDT by Nan Wang
Modified: 2017-07-21 16:25 PDT (History)
4 users (show)

See Also:


Attachments
patch (9.03 KB, patch)
2017-07-21 12:31 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (8.20 KB, patch)
2017-07-21 15:37 PDT, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2017-07-21 12:22:33 PDT
Expose form validation on iOS as hint
Comment 1 Radar WebKit Bug Importer 2017-07-21 12:23:43 PDT
<rdar://problem/33459761>
Comment 2 Nan Wang 2017-07-21 12:31:08 PDT
Created attachment 316110 [details]
patch
Comment 3 chris fleizach 2017-07-21 12:47:08 PDT
Comment on attachment 316110 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316110&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1590
> +    if (is<HTMLFormControlElement>(m_renderer->node()))

you should be able to just call node() here

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1597
> +    if (is<HTMLFormControlElement>(m_renderer->node()))

ditto

then you can probably just put this in AccessibilityObject so it doesn't have to be virtual
Comment 4 Nan Wang 2017-07-21 15:37:04 PDT
Created attachment 316129 [details]
patch

update from review
Comment 5 chris fleizach 2017-07-21 15:53:11 PDT
Comment on attachment 316129 [details]
patch

looks good, wait for bot status = green
Comment 6 WebKit Commit Bot 2017-07-21 16:25:25 PDT
Comment on attachment 316129 [details]
patch

Clearing flags on attachment: 316129

Committed r219751: <http://trac.webkit.org/changeset/219751>
Comment 7 WebKit Commit Bot 2017-07-21 16:25:27 PDT
All reviewed patches have been landed.  Closing bug.