Bug 174721 - WebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from several threads
Summary: WebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-21 12:14 PDT by Chris Dumez
Modified: 2017-07-21 13:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2017-07-21 12:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-21 12:14:20 PDT 
WebResourceLoadStatisticsStore::m_operatingDates is unsafely modified from several threads.
Comment 1 Chris Dumez 2017-07-21 12:14:46 PDT 
<rdar://problem/33400343>
Comment 2 Chris Dumez 2017-07-21 12:18:46 PDT 
Created attachment 316108 [details]
Patch
Comment 3 Brent Fulgham 2017-07-21 13:32:17 PDT 
Comment on attachment 316108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316108&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:286
> +    });

I didn’t look closely enough at what that routine did! Thank you for fixing this.
Comment 4 WebKit Commit Bot 2017-07-21 13:40:17 PDT 
Comment on attachment 316108 [details]
Patch

Clearing flags on attachment: 316108

Committed r219739: <http://trac.webkit.org/changeset/219739>
Comment 5 WebKit Commit Bot 2017-07-21 13:40:18 PDT 
All reviewed patches have been landed.  Closing bug.