Bug 174706 - Noise when AudioChannel lengths don't match.
Summary: Noise when AudioChannel lengths don't match.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-20 22:02 PDT by Jeremy Jones
Modified: 2017-07-21 12:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2017-07-20 22:27 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2017-07-21 12:33 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch for landing. (1.52 KB, patch)
2017-07-21 12:34 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-07-20 22:02:57 PDT 
Noise when AudioChannel lengths don't match.
Comment 1 Jeremy Jones 2017-07-20 22:03:25 PDT 
<rdar://problem/33389856> WebRTC 17A320/B188: Blaring static through AirPods when allowing camera/mic on webrtc session
Comment 2 Jeremy Jones 2017-07-20 22:27:02 PDT 
Created attachment 316068 [details]
Patch
Comment 3 Eric Carlson 2017-07-21 06:41:08 PDT 
Comment on attachment 316068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316068&action=review

> Source/WebCore/ChangeLog:9
> +        When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer.

Nit: "it don't do the copy. This leaves uninitialized data in the audio buffer." => "returning early leaves uninitialized data in the audio buffer."
Comment 4 Jeremy Jones 2017-07-21 12:31:12 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 316068 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316068&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer.
> 
> Nit: "it don't do the copy. This leaves uninitialized data in the audio
> buffer." => "returning early leaves uninitialized data in the audio buffer."

"When AudioChannel lengths don't match it returns early leaving uninitialized data in the audio buffer."
Comment 5 Jeremy Jones 2017-07-21 12:33:05 PDT 
Created attachment 316111 [details]
Patch
Comment 6 Jeremy Jones 2017-07-21 12:34:24 PDT 
Created attachment 316112 [details]
Patch for landing.
Comment 7 Jeremy Jones 2017-07-21 12:35:23 PDT 
Eric, I accidentally wiped out your r+.
Comment 8 WebKit Commit Bot 2017-07-21 12:48:52 PDT 
Comment on attachment 316112 [details]
Patch for landing.

Clearing flags on attachment: 316112

Committed r219736: <http://trac.webkit.org/changeset/219736>
Comment 9 WebKit Commit Bot 2017-07-21 12:48:53 PDT 
All reviewed patches have been landed.  Closing bug.