Bug 174706 – Noise when AudioChannel lengths don't match.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Noise when AudioChannel lengths don't match.

[Jeremy Jones]

<rdar://problem/33389856> WebRTC 17A320/B188: Blaring static through AirPods when allowing camera/mic on webrtc session

[Jeremy Jones]

Created attachment 316068 [details]
Patch

[Eric Carlson]

Comment on attachment 316068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316068&action=review

> Source/WebCore/ChangeLog:9
> +        When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer.

Nit: "it don't do the copy. This leaves uninitialized data in the audio buffer." => "returning early leaves uninitialized data in the audio buffer."

[Jeremy Jones]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 316068 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316068&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        When AudioChannel lengths don't match, it don't do the copy. This leaves uninitialized data in the audio buffer.
> 
> Nit: "it don't do the copy. This leaves uninitialized data in the audio
> buffer." => "returning early leaves uninitialized data in the audio buffer."

"When AudioChannel lengths don't match it returns early leaving uninitialized data in the audio buffer."

[Jeremy Jones]

Created attachment 316111 [details]
Patch

[Jeremy Jones]

Created attachment 316112 [details]
Patch for landing.

[Jeremy Jones]

Eric, I accidentally wiped out your r+.

[WebKit Commit Bot]

Comment on attachment 316112 [details]
Patch for landing.

Clearing flags on attachment: 316112

Committed r219736: <http://trac.webkit.org/changeset/219736>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.