Bug 174705 - [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
Summary: [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-20 20:56 PDT by Yusuke Suzuki
Modified: 2017-07-22 00:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.48 KB, patch)
2017-07-20 21:00 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-07-20 20:56:15 PDT 
[WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
Comment 1 Yusuke Suzuki 2017-07-20 21:00:24 PDT 
Created attachment 316066 [details]
Patch
Comment 2 Mark Lam 2017-07-21 12:21:16 PDT 
Comment on attachment 316066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316066&action=review

r=me

> Source/WTF/wtf/ThreadGroup.cpp:53
> +    ThreadGroupAddResult result = add(Thread::current());

auto result?
Comment 3 Yusuke Suzuki 2017-07-21 22:13:59 PDT 
Comment on attachment 316066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316066&action=review

Thank you!

>> Source/WTF/wtf/ThreadGroup.cpp:53
>> +    ThreadGroupAddResult result = add(Thread::current());
> 
> auto result?

Sounds fine. Fixed.
Comment 4 Yusuke Suzuki 2017-07-22 00:27:11 PDT 
Committed r219760: <http://trac.webkit.org/changeset/219760>