Bug 174699 – Drop make_dom_exceptions.pl script that we only have DOMException

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Drop make_dom_exceptions.pl script once we only have 1 exception type: DOMException.

[Chris Dumez]

Created attachment 316098 [details]
WIP Patch

[Build Bot]

Attachment 316098 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 316102 [details]
WIP Patch

[Build Bot]

Attachment 316102 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 316106 [details]
Patch

[Darin Adler]

Comment on attachment 316106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316106&action=review

> Source/WebCore/dom/ExceptionCodeDescription.h:37
> +#if ENABLE(INDEXED_DATABASE)
> +    IDBDatabaseExceptionType,
> +#endif

Is this staying for good? Or will this be merged later?

> Source/WebCore/inspector/WebInjectedScriptHost.cpp:30
> +#include "DOMException.h"
> +#include "JSDOMException.h"

Surprised we need both of these. I would have thought we would only need JSDOMException.h

[Chris Dumez]

(In reply to Darin Adler from comment #6)
> Comment on attachment 316106 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316106&action=review
> 
> > Source/WebCore/dom/ExceptionCodeDescription.h:37
> > +#if ENABLE(INDEXED_DATABASE)
> > +    IDBDatabaseExceptionType,
> > +#endif
> 
> Is this staying for good? Or will this be merged later?

I plan to investigate dropping IDBDatabaseException in a follow-up, given that is the last "custom" exception and dropping it would help simplify the code further.
That said, I might run into trouble when trying to get rid of it, we'll see.

> 
> > Source/WebCore/inspector/WebInjectedScriptHost.cpp:30
> > +#include "DOMException.h"
> > +#include "JSDOMException.h"
> 
> Surprised we need both of these. I would have thought we would only need
> JSDOMException.h

I'll double check.

[WebKit Commit Bot]

Comment on attachment 316106 [details]
Patch

Clearing flags on attachment: 316106

Committed r219741: <http://trac.webkit.org/changeset/219741>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.