Bug 174695 – Drop legacy SVGException type

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Chris Dumez]

Drop legacy SVGException type. It is not longer part of the specification (replaced by DOMException). Both Firefox and Chrome no longer expose it.

[Chris Dumez]

Created attachment 316039 [details]
Patch

[Build Bot]

Comment on attachment 316039 [details]
Patch

Attachment 316039 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4158183

New failing tests:
fast/dom/Window/window-lookup-precedence.html

[Build Bot]

Created attachment 316048 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 316039 [details]
Patch

Attachment 316039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4158187

New failing tests:
fast/dom/Window/window-lookup-precedence.html

[Build Bot]

Created attachment 316050 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Darin Adler]

Comment on attachment 316039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316039&action=review

r=me assuming you can get everything to compile and all the tests to pass; not sure why there are EWS failures

> Source/WebCore/bindings/js/JSExceptionBase.cpp:36
>  ExceptionBase* toExceptionBase(JSC::VM& vm, JSC::JSValue value)
>  {
> -    if (DOMCoreException* domException = JSDOMCoreException::toWrapped(vm, value))
> -        return reinterpret_cast<ExceptionBase*>(domException);
> -    if (SVGException* svgException = JSSVGException::toWrapped(vm, value))
> -        return reinterpret_cast<ExceptionBase*>(svgException);
> -
> -    return nullptr;
> +    return reinterpret_cast<ExceptionBase*>(JSDOMCoreException::toWrapped(vm, value));
>  }

Is this something you will be removing in a future patch?

> Source/WebCore/svg/SVGPathSegList.h:73
> +    ExceptionOr<RefPtr<SVGPathSeg>> initialize(Ref<SVGPathSeg>&& newItem)

Why RefPtr instead of Ref? The IDL file does not indicate a nullable return type. I think this should use Ref for the return type. Probably just need to add some releaseNonNull() to implementation in a few places.

> Source/WebCore/svg/SVGPathSegList.h:79
> +    ExceptionOr<RefPtr<SVGPathSeg>> getItem(unsigned index);

Ditto.

> Source/WebCore/svg/SVGPathSegList.h:81
> +    ExceptionOr<RefPtr<SVGPathSeg>> insertItemBefore(Ref<SVGPathSeg>&& newItem, unsigned index)

Ditto.

> Source/WebCore/svg/SVGPathSegList.h:86
> +    ExceptionOr<RefPtr<SVGPathSeg>> replaceItem(Ref<SVGPathSeg>&&, unsigned index);

Ditto.

> Source/WebCore/svg/SVGPathSegList.h:88
> +    ExceptionOr<RefPtr<SVGPathSeg>> removeItem(unsigned index);

Ditto.

> Source/WebCore/svg/SVGPathSegList.h:90
> +    ExceptionOr<RefPtr<SVGPathSeg>> appendItem(Ref<SVGPathSeg>&& newItem)

Ditto.

[Build Bot]

Comment on attachment 316039 [details]
Patch

Attachment 316039 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4158197

New failing tests:
fast/dom/Window/window-lookup-precedence.html

[Build Bot]

Created attachment 316051 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

Comment on attachment 316039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316039&action=review

>> Source/WebCore/bindings/js/JSExceptionBase.cpp:36
>>  }
> 
> Is this something you will be removing in a future patch?

Will see if this is a small enough change to drop in this patch. But yes, follow-up clean up is planned.

>> Source/WebCore/svg/SVGPathSegList.h:73
>> +    ExceptionOr<RefPtr<SVGPathSeg>> initialize(Ref<SVGPathSeg>&& newItem)
> 
> Why RefPtr instead of Ref? The IDL file does not indicate a nullable return type. I think this should use Ref for the return type. Probably just need to add some releaseNonNull() to implementation in a few places.

Will see if this is a small change to do in this patch.

[Chris Dumez]

Comment on attachment 316039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316039&action=review

>>> Source/WebCore/bindings/js/JSExceptionBase.cpp:36
>>>  }
>> 
>> Is this something you will be removing in a future patch?
> 
> Will see if this is a small enough change to drop in this patch. But yes, follow-up clean up is planned.

Dropped in the next iteration.

>>> Source/WebCore/svg/SVGPathSegList.h:73
>>> +    ExceptionOr<RefPtr<SVGPathSeg>> initialize(Ref<SVGPathSeg>&& newItem)
>> 
>> Why RefPtr instead of Ref? The IDL file does not indicate a nullable return type. I think this should use Ref for the return type. Probably just need to add some releaseNonNull() to implementation in a few places.
> 
> Will see if this is a small change to do in this patch.

I can look into it for a follow up. This is a larger change because it requires modifying SVGListProperty and all its subclasses.

[Chris Dumez]

Created attachment 316056 [details]
Patch

[Chris Dumez]

Comment on attachment 316056 [details]
Patch

Clearing flags on attachment: 316056

Committed r219712: <http://trac.webkit.org/changeset/219712>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 316056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316056&action=review

> Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp:66
> +    if (auto* domException = JSDOMCoreException::toWrapped(vm, exception))
> +        return domException->toString();

I think I would have called this “unwrappedException” or "underlyingException".