Bug 174693 – Get rid of IconDatabase related code in WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

Get rid of IconDatabase related code in WebKit

(As much as possible)

[Brady Eidson]

Created attachment 316033 [details]
Patch

[Brady Eidson]

Let EWS work.

[Brady Eidson]

Created attachment 316035 [details]
Patch

[Build Bot]

Attachment 316035 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:37:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 316040 [details]
Patch with <tab> fixed

Not marking as a patch yet, waiting for EWS to finish on the last one.

[Brady Eidson]

Ran API tests locally, have some API test failures to resolve (by getting rid of them)

  IconLoading.AlreadyCachedIcon
  IconLoading.DefaultFavicon
  IconLoading.IconLoadCancelledCallback
  IconLoading.IconLoadCancelledCallback2

Will do those with an updated patch for landing.

(EWS SHOULD DO API TESTS!)

[Brady Eidson]

(In reply to Brady Eidson from comment #6)
> Ran API tests locally, have some API test failures to resolve (by getting
> rid of them)
> 
>   IconLoading.AlreadyCachedIcon
>   IconLoading.DefaultFavicon
>   IconLoading.IconLoadCancelledCallback
>   IconLoading.IconLoadCancelledCallback2
> 
> Will do those with an updated patch for landing.
> 
> (EWS SHOULD DO API TESTS!)

Whoops, these are actually *new* tests. I know what I did wrong here. One line change in WebFrameLoaderClient, I think.

[Brady Eidson]

Created attachment 316065 [details]
Patch

[Brady Eidson]

(In reply to Brady Eidson from comment #7)
> (In reply to Brady Eidson from comment #6)
> > Ran API tests locally, have some API test failures to resolve (by getting
> > rid of them)
> > 
> >   IconLoading.AlreadyCachedIcon
> >   IconLoading.DefaultFavicon
> >   IconLoading.IconLoadCancelledCallback
> >   IconLoading.IconLoadCancelledCallback2
> > 
> > Will do those with an updated patch for landing.
> > 
> > (EWS SHOULD DO API TESTS!)
> 
> Whoops, these are actually *new* tests. I know what I did wrong here. One
> line change in WebFrameLoaderClient, I think.

Yup, I'd accidentally taken off the WebFrameLoaderClient method that tells WebCore to use icon loading client mode.

[WebKit Commit Bot]

Comment on attachment 316065 [details]
Patch

Clearing flags on attachment: 316065

Committed r219713: <http://trac.webkit.org/changeset/219713>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.