Bug 174673 - [WPE] Missing keyboard event information breaks fast/events/arrow-keys-on-body.html
Summary: [WPE] Missing keyboard event information breaks fast/events/arrow-keys-on-bod...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-20 07:08 PDT by Claudio Saavedra
Modified: 2018-09-17 05:21 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2017-07-20 07:08:20 PDT
fast/events/arrow-keys-on-body.html fails because key information is missing from the keyboard event created by WPE WebEventFactory.

-BODY - keydown - false,false,false,false - ArrowLeft - ArrowLeft - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
-BODY - keyup - false,false,false,false - ArrowLeft - ArrowLeft - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
+BODY - keydown - false,false,false,false - undefined - undefined - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37
+BODY - keyup - false,false,false,false - undefined - undefined - Left - DOM_KEY_LOCATION_STANDARD - 37 - 0 - 37 - 37

The missing properties are event.key and event.code. This seems to be because we're using the default WebKeyboardEvent() constructor that doesn't fill in these properties as other ports do.
Comment 1 Claudio Saavedra 2017-07-20 11:07:00 PDT
Other affected tests:

webkit.org/b/174673 fast/events/keyboardevent-code.html [ Failure ]
webkit.org/b/174673 fast/events/keyboardevent-key.html [ Failure ]
webkit.org/b/174673 fast/events/key-events-in-input-button.html [ Failure ]
webkit.org/b/174673 fast/events/key-events-in-input-text.html [ Failure ]
webkit.org/b/174673 fast/events/special-key-events-in-input-text.html [ Failure ]
Comment 2 Claudio Saavedra 2018-09-17 05:21:44 PDT
Seems that the only one still failing here is fast/events/keyboardevent-code.html. The others got fixed recently as the missing bits were added.