Bug 174668 - WebDriver: correctly handle main frame handles
Summary: WebDriver: correctly handle main frame handles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 174670
  Show dependency tree / graph
 
Reported: 2017-07-19 23:58 PDT by Carlos Garcia Campos
Modified: 2017-07-21 02:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.97 KB, patch)
2017-07-20 00:01 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-07-19 23:58:12 PDT 
When I switched to use std::optional instead of empty strings for the browsing contexts in WebDriver, I forgot that automation uses empty string for frames to refer to the main frame. We should handle that case, because we are currently considering empty strings as valid browsing context. It's not a big deal because Automation converts back the empty string received to the main frame, though. We should also ensure we close the current browsing context when switching to a new top level browsing context.
Comment 1 Carlos Garcia Campos 2017-07-20 00:01:16 PDT 
Created attachment 315973 [details]
Patch
Comment 2 BJ Burg 2017-07-20 10:26:23 PDT 
Comment on attachment 315973 [details]
Patch

r=me
Comment 3 Carlos Garcia Campos 2017-07-21 02:43:24 PDT 
Committed r219721: <http://trac.webkit.org/changeset/219721>