Bug 174666 - WKHTTPCookieStore API tests fail on High Sierra
Summary: WKHTTPCookieStore API tests fail on High Sierra
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 21:11 PDT by Brady Eidson
Modified: 2019-12-12 09:47 PST (History)
14 users (show)

See Also:

Attachments
Patch (8.41 KB, patch)
2017-07-19 21:21 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.41 KB, patch)
2017-07-19 21:37 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-07-19 21:11:39 PDT 
WKHTTPCookieStore API tests fail on High Sierra

Some of the CFNetwork SPI we were using stopped working on High Sierra.

I have a workaround.

rdar://problem/33410271
Comment 1 Brady Eidson 2017-07-19 21:21:15 PDT 
Created attachment 315968 [details]
Patch
Comment 2 Build Bot 2017-07-19 21:23:55 PDT 
Attachment 315968 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/CookieStorageObserver.mm:63:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andy Estes 2017-07-19 21:32:15 PDT 
Comment on attachment 315968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315968&action=review

> Source/WebCore/platform/network/cocoa/CookieStorageObserver.mm:44
> +-(instancetype)initWithObserver:(WebCore::CookieStorageObserver&)theObserver;

Space after the - (and ditto everywhere else)
Comment 4 Brady Eidson 2017-07-19 21:37:31 PDT 
Created attachment 315969 [details]
Patch
Comment 5 WebKit Commit Bot 2017-07-20 07:28:22 PDT 
Comment on attachment 315969 [details]
Patch

Clearing flags on attachment: 315969

Committed r219683: <http://trac.webkit.org/changeset/219683>
Comment 6 WebKit Commit Bot 2017-07-20 07:28:23 PDT 
All reviewed patches have been landed.  Closing bug.