This would allow users to quickly jump to the line of code responsible for the selected action.
Created attachment 316941 [details] Patch
Comment on attachment 316941 [details] Patch Attachment 316941 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4238619 New failing tests: inspector/canvas/recording-2d.html inspector/model/recording.html
Created attachment 316947 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316941 [details] Patch Attachment 316941 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4238662 New failing tests: inspector/canvas/recording-2d.html inspector/model/recording.html
Created attachment 316949 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 316941 [details] Patch Attachment 316941 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4239021 New failing tests: inspector/canvas/recording-2d.html inspector/model/recording.html
Created attachment 316951 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 317015 [details] Patch
Created attachment 317016 [details] [Image] After Patch is applied
Comment on attachment 317015 [details] Patch Attachment 317015 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4242892 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html
Created attachment 317050 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 317015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317015&action=review r=me > Source/JavaScriptCore/inspector/ScriptCallFrame.h:55 > + bool operator==(const ScriptCallFrame& o) const { return isEqual(o); } Style: Do not abbreviate names. Use `other`. > Source/WebCore/inspector/InspectorCanvas.cpp:283 > + auto array = Inspector::Protocol::Array<double>::create(); Style: Just put `item =` here instead of the temp? > Source/WebCore/inspector/InspectorCanvas.cpp:461 > + if (visitor->isNativeFrame() && !trace->length()) Style: Lets swap these for readability. Also a length check is probably simpler. > Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:117 > + } catch (e) { > + // Ignored. > + } You could be the first adopter of the parameterless catch!! try { ... } catch { }
Created attachment 317076 [details] Patch
Created attachment 317080 [details] Patch
Comment on attachment 317015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317015&action=review >> Source/WebCore/inspector/InspectorCanvas.cpp:283 >> + auto array = Inspector::Protocol::Array<double>::create(); > > Style: Just put `item =` here instead of the temp? I can't do this because item is an InspectorValue and will not have the addItem function. >> Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:117 >> + } > > You could be the first adopter of the parameterless catch!! > > try { > ... > } catch { } One reason I added the "// Ignored." is for ESLint, but that's ignorable :P
Comment on attachment 317080 [details] Patch Clearing flags on attachment: 317080 Committed r220188: <http://trac.webkit.org/changeset/220188>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33694023>