Bug 174655 – AX: Web page reloaded when a node is labelling multiple childnodes

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

stuck in a loop

298 com.apple.WebCore             	0x00007fffb3446745 WebCore::accessibleNameForNode(WebCore::Node*, WebCore::Node*) + 549
299 com.apple.WebCore             	0x00007fffb3448b01 WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements(WTF::Vector<WebCore::Element*, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 129
300 com.apple.WebCore             	0x00007fffb3448ca3 WebCore::AccessibilityNodeObject::ariaLabeledByAttribute() const + 83
301 com.apple.WebCore             	0x00007fffb3446248 WebCore::AccessibilityNodeObject::ariaLabeledByText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 40
302 com.apple.WebCore             	0x00007fffb3445575 WebCore::AccessibilityNodeObject::alternativeText(WTF::Vector<WebCore::AccessibilityText, 0ul, WTF::CrashOnOverflow, 16ul>&) const + 277
303 com.apple.WebCore             	0x00007fffb3447ae3 WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 483
304 com.apple.WebCore             	0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770
305 com.apple.WebCore             	0x00007fffb3447b2d WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 557
306 com.apple.WebCore             	0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770
307 com.apple.WebCore             	0x00007fffb3447b2d WebCore::AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 557
308 com.apple.WebCore             	0x00007fffb3459b12 WebCore::AccessibilityRenderObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 770
309 com.apple.WebCore             	0x00007fffb3446745 WebCore::accessibleNameForNode(WebCore::Node*, WebCore::Node*) + 549

<rdar://problem/32853980>

[Nan Wang]

Created attachment 315939 [details]
patch

[chris fleizach]

Comment on attachment 315939 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315939&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1738
> +            downcast<AccessibilityNodeObject>(*child).ariaLabeledByElements(labeledByElements);

is it necessary to do this downcast? isn't ariaLabeledByElements on AXObject?

[Nan Wang]

Comment on attachment 315939 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315939&action=review

>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1738
>> +            downcast<AccessibilityNodeObject>(*child).ariaLabeledByElements(labeledByElements);
> 
> is it necessary to do this downcast? isn't ariaLabeledByElements on AXObject?

NO, it's only on AXNodeObject

[WebKit Commit Bot]

Comment on attachment 315939 [details]
patch

Clearing flags on attachment: 315939

Committed r219661: <http://trac.webkit.org/changeset/219661>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.