Bug 174654 - [Curl] Move response related features into ResourceResponse
Summary: [Curl] Move response related features into ResourceResponse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 173964
  Show dependency tree / graph
 
Reported: 2017-07-19 10:30 PDT by Basuke Suzuki
Modified: 2017-09-27 12:49 PDT (History)
7 users (show)

See Also:

Attachments
Implemented (9.25 KB, patch)
2017-08-03 14:27 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Implemented (10.58 KB, patch)
2017-08-03 14:35 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Implemented (10.79 KB, patch)
2017-08-03 16:46 PDT, Basuke Suzuki 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch (15.09 KB, patch)
2017-09-13 16:35 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-07-19 10:30:06 PDT 
ResourceHandle currently handles resource header handling in it, but ResourceResponse class can handle directly from CurlContext.
Comment 1 Basuke Suzuki 2017-08-03 14:27:45 PDT 
Created attachment 317152 [details]
Implemented
Comment 2 Basuke Suzuki 2017-08-03 14:35:09 PDT 
Created attachment 317155 [details]
Implemented
Comment 3 Basuke Suzuki 2017-08-03 16:46:54 PDT 
Created attachment 317179 [details]
Implemented
Comment 4 Brent Fulgham 2017-08-18 09:34:02 PDT 
Comment on attachment 317179 [details]
Implemented

View in context: https://bugs.webkit.org/attachment.cgi?id=317179&action=review

This looks good to me. I wasn't sure if you meant to get rid of the notes about the cURL FOLLOWLOCATION option. r=me, but not cq+ until you answer that.

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:-721
> -        // will be called more than one time with the line starting "HTTP" for one job.

This information seems to have been lost in your patch. Is this no longer relevant or useful to you?
Comment 5 Basuke Suzuki 2017-09-13 16:35:03 PDT 
Created attachment 320708 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-13 23:57:15 PDT 
Comment on attachment 320708 [details]
Patch

Clearing flags on attachment: 320708

Committed r222012: <http://trac.webkit.org/changeset/222012>
Comment 7 WebKit Commit Bot 2017-09-13 23:57:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:49:18 PDT 
<rdar://problem/34694080>