WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174654
[Curl] Move response related features into ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=174654
Summary
[Curl] Move response related features into ResourceResponse
Basuke Suzuki
Reported
2017-07-19 10:30:06 PDT
ResourceHandle currently handles resource header handling in it, but ResourceResponse class can handle directly from CurlContext.
Attachments
Implemented
(9.25 KB, patch)
2017-08-03 14:27 PDT
,
Basuke Suzuki
no flags
Details
Formatted Diff
Diff
Implemented
(10.58 KB, patch)
2017-08-03 14:35 PDT
,
Basuke Suzuki
no flags
Details
Formatted Diff
Diff
Implemented
(10.79 KB, patch)
2017-08-03 16:46 PDT
,
Basuke Suzuki
bfulgham
: review+
bfulgham
: commit-queue-
Details
Formatted Diff
Diff
Patch
(15.09 KB, patch)
2017-09-13 16:35 PDT
,
Basuke Suzuki
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Basuke Suzuki
Comment 1
2017-08-03 14:27:45 PDT
Created
attachment 317152
[details]
Implemented
Basuke Suzuki
Comment 2
2017-08-03 14:35:09 PDT
Created
attachment 317155
[details]
Implemented
Basuke Suzuki
Comment 3
2017-08-03 16:46:54 PDT
Created
attachment 317179
[details]
Implemented
Brent Fulgham
Comment 4
2017-08-18 09:34:02 PDT
Comment on
attachment 317179
[details]
Implemented View in context:
https://bugs.webkit.org/attachment.cgi?id=317179&action=review
This looks good to me. I wasn't sure if you meant to get rid of the notes about the cURL FOLLOWLOCATION option. r=me, but not cq+ until you answer that.
> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:-721 > - // will be called more than one time with the line starting "HTTP" for one job.
This information seems to have been lost in your patch. Is this no longer relevant or useful to you?
Basuke Suzuki
Comment 5
2017-09-13 16:35:03 PDT
Created
attachment 320708
[details]
Patch
WebKit Commit Bot
Comment 6
2017-09-13 23:57:15 PDT
Comment on
attachment 320708
[details]
Patch Clearing flags on attachment: 320708 Committed
r222012
: <
http://trac.webkit.org/changeset/222012
>
WebKit Commit Bot
Comment 7
2017-09-13 23:57:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2017-09-27 12:49:18 PDT
<
rdar://problem/34694080
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug