Bug 174653 - [Win] Async image tests are failing.
Summary: [Win] Async image tests are failing.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on: 174451
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-19 09:43 PDT by Per Arne Vollan
Modified: 2020-05-30 19:32 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.74 KB, patch)
2017-07-19 09:45 PDT, Per Arne Vollan
mjs: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-07-19 09:43:21 PDT
fast/images/async-image-background-image-repeated.html [ Timeout ]
fast/images/async-image-background-image.html [ Timeout ]
fast/images/async-image-body-background-image.html [ Timeout ]
fast/images/async-image-multiple-clients-repaint.html [ Timeout ]
fast/images/sprite-sheet-image-draw.html [ Timeout ]
Comment 1 Per Arne Vollan 2017-07-19 09:45:26 PDT
Created attachment 315925 [details]
Patch
Comment 2 Said Abou-Hallawa 2017-07-19 16:02:36 PDT
Please hold on this patch. I am renaming the flag because the new name PaintBehaviorAllowAsyncImageDecoding caused too much confusion. I am returning it back to its original name PaintBehaviorSnapshotting and I am adding a new one which is named PaintBehaviorTileFirstPaint.
Comment 3 Per Arne Vollan 2017-07-19 16:33:30 PDT
(In reply to Said Abou-Hallawa from comment #2)
> Please hold on this patch. I am renaming the flag because the new name
> PaintBehaviorAllowAsyncImageDecoding caused too much confusion. I am
> returning it back to its original name PaintBehaviorSnapshotting and I am
> adding a new one which is named PaintBehaviorTileFirstPaint.

Ok, thanks Said!
Comment 4 Per Arne Vollan 2017-07-24 15:53:27 PDT
Updated test expectations in <https://trac.webkit.org/changeset/219844/webkit>.
Comment 5 Brent Fulgham 2017-08-18 09:49:41 PDT
Is this patch in the right state now? Can we land it, Said?
Comment 6 Said Abou-Hallawa 2017-08-18 11:07:32 PDT
(In reply to Brent Fulgham from comment #5)
> Is this patch in the right state now? Can we land it, Said?

No. The enum names have been changed.

Please have a look at the changes of <http://trac.webkit.org/changeset/219876> in WebKitLegacy/mac/WebView/WebFrame.mm.
Comment 7 Maciej Stachowiak 2020-05-30 19:32:59 PDT
Comment on attachment 315925 [details]
Patch

This patch needs to be updated to apply cleanly.