Bug 174651 - Minor Node->Element type tightening fixes
Summary: Minor Node->Element type tightening fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 07:36 PDT by Andreas Kling
Modified: 2017-07-20 07:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.25 KB, patch)
2017-07-19 07:39 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-07-19 07:36:19 PDT
Accumulated some minor Node* -> Element*/Element& changes while passing through focus code.
Comment 1 Andreas Kling 2017-07-19 07:39:39 PDT
Created attachment 315919 [details]
Patch
Comment 2 Build Bot 2017-07-19 07:41:39 PDT
Attachment 315919 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/Editor.h:404:  The parameter name "selection" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2017-07-19 22:16:33 PDT
Comment on attachment 315919 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315919&action=review

> Source/WebCore/dom/Document.cpp:386
> +    Frame* frame = element.document().frame();

You could use auto* here.

> Source/WebCore/editing/Editor.cpp:466
> +    Element* target = findEventTargetFromSelection();

You could use auto* here.

> Source/WebCore/editing/Editor.cpp:474
> +    Element* target = findEventTargetFromSelection();

You could use auto* here.

> Source/WebCore/editing/Editor.cpp:782
> +    Element* target = findEventTargetFromSelection();

You could use auto* here.

> Source/WebCore/editing/Editor.cpp:809
> +    Element* target = selection.start().element();

You could use auto* here.
Comment 4 WebKit Commit Bot 2017-07-20 07:37:18 PDT
Comment on attachment 315919 [details]
Patch

Clearing flags on attachment: 315919

Committed r219685: <http://trac.webkit.org/changeset/219685>
Comment 5 WebKit Commit Bot 2017-07-20 07:37:19 PDT
All reviewed patches have been landed.  Closing bug.