Accumulated some minor Node* -> Element*/Element& changes while passing through focus code.
Created attachment 315919 [details] Patch
Attachment 315919 [details] did not pass style-queue: ERROR: Source/WebCore/editing/Editor.h:404: The parameter name "selection" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 315919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315919&action=review > Source/WebCore/dom/Document.cpp:386 > + Frame* frame = element.document().frame(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:466 > + Element* target = findEventTargetFromSelection(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:474 > + Element* target = findEventTargetFromSelection(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:782 > + Element* target = findEventTargetFromSelection(); You could use auto* here. > Source/WebCore/editing/Editor.cpp:809 > + Element* target = selection.start().element(); You could use auto* here.
Comment on attachment 315919 [details] Patch Clearing flags on attachment: 315919 Committed r219685: <http://trac.webkit.org/changeset/219685>
All reviewed patches have been landed. Closing bug.