Bug 174650 – [iOS] REGRESSION: Scrubbing media using built-in controls does not pause media

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

When scrubbing media with the built-in controls, the media isn't paused as it is on macOS. This is a regression over iOS 10.

[Radar WebKit Bug Importer]

<rdar://problem/33401877>

[Antoine Quint]

Created attachment 315920 [details]
Patch

[Build Bot]

Comment on attachment 315920 [details]
Patch

Attachment 315920 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4148350

New failing tests:
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html

[Build Bot]

Created attachment 315926 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Antoine Quint]

Created attachment 315927 [details]
Patch

[Dean Jackson]

Comment on attachment 315927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315927&action=review

> Source/WebCore/Modules/modern-media-controls/controls/slider.js:192
> +        // so the value shoudl be read back from it dynamically.

typo

[Antoine Quint]

Created attachment 315948 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 315948 [details]
Patch for landing

Clearing flags on attachment: 315948

Committed r219662: <http://trac.webkit.org/changeset/219662>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

The test added with this patch:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html
is extremely flaky and fails most of the time according to the dashboard.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fscrubber-support%2Fscrubber-support-drag.html

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r219683%20(2215)/results.html

Diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/scrubber-support/scrubber-support-drag-actual.txt
@@ -4,7 +4,7 @@
 
 
 PASS media.currentTime is within 0.2 of 3.0136
-PASS media.currentTime is 0
+FAIL media.currentTime should be 0. Was 3.1872.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Antoine Quint]

Flaky test followup is at https://bugs.webkit.org/show_bug.cgi?id=174682.