Bug 174650 - [iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
Summary: [iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad iOS 11
: P2 Critical
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-19 07:18 PDT by Antoine Quint
Modified: 2017-07-20 12:23 PDT (History)
5 users (show)

See Also:


Attachments
Patch (19.12 KB, patch)
2017-07-19 08:09 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (11.74 MB, application/zip)
2017-07-19 09:49 PDT, Build Bot
no flags Details
Patch (19.73 KB, patch)
2017-07-19 09:54 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (19.73 KB, patch)
2017-07-19 12:34 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-07-19 07:18:05 PDT
When scrubbing media with the built-in controls, the media isn't paused as it is on macOS. This is a regression over iOS 10.
Comment 1 Radar WebKit Bug Importer 2017-07-19 07:18:22 PDT
<rdar://problem/33401877>
Comment 2 Antoine Quint 2017-07-19 08:09:09 PDT
Created attachment 315920 [details]
Patch
Comment 3 Build Bot 2017-07-19 09:49:45 PDT
Comment on attachment 315920 [details]
Patch

Attachment 315920 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4148350

New failing tests:
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html
Comment 4 Build Bot 2017-07-19 09:49:47 PDT
Created attachment 315926 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 5 Antoine Quint 2017-07-19 09:54:12 PDT
Created attachment 315927 [details]
Patch
Comment 6 Dean Jackson 2017-07-19 12:18:08 PDT
Comment on attachment 315927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315927&action=review

> Source/WebCore/Modules/modern-media-controls/controls/slider.js:192
> +        // so the value shoudl be read back from it dynamically.

typo
Comment 7 Antoine Quint 2017-07-19 12:34:24 PDT
Created attachment 315948 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-07-19 13:13:18 PDT
Comment on attachment 315948 [details]
Patch for landing

Clearing flags on attachment: 315948

Committed r219662: <http://trac.webkit.org/changeset/219662>
Comment 9 WebKit Commit Bot 2017-07-19 13:13:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Matt Lewis 2017-07-20 10:23:00 PDT
The test added with this patch:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html
is extremely flaky and fails most of the time according to the dashboard.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fscrubber-support%2Fscrubber-support-drag.html

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r219683%20(2215)/results.html

Diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/scrubber-support/scrubber-support-drag-actual.txt
@@ -4,7 +4,7 @@
 
 
 PASS media.currentTime is within 0.2 of 3.0136
-PASS media.currentTime is 0
+FAIL media.currentTime should be 0. Was 3.1872.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 11 Antoine Quint 2017-07-20 12:23:24 PDT
Flaky test followup is at https://bugs.webkit.org/show_bug.cgi?id=174682.