Bug 174627 - [iOS] WebKit media controls are sometimes shown after exiting full screen on vimeo.com
Summary: [iOS] WebKit media controls are sometimes shown after exiting full screen on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified iOS 11
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-18 07:16 PDT by Antoine Quint
Modified: 2017-07-18 12:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.03 KB, patch)
2017-07-18 07:44 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (6.07 KB, patch)
2017-07-18 12:21 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-07-18 07:16:15 PDT
Steps to reproduce:

1. go to https://vimeo.com/225249697
2. tap to start the video
3. enter fullscreen
4. exit fullscreen by tapping the X icon

Both the WebKit media controls and the Vimeo custom controls appear sometimes, but not always. This is due to https://bugs.webkit.org/show_bug.cgi?id=174626, where the "webkitfullscreenchange" event isn't fired when entering or exiting fullscreen, so depending on when the "play" or "pause" event fires, the ControlsVisibilitySupport object may think that the controls are still in fullscreen and not get an event that we exited fullscreen.
Comment 1 Antoine Quint 2017-07-18 07:20:51 PDT
<rdar://problem/33301005>
Comment 2 Antoine Quint 2017-07-18 07:44:20 PDT
Created attachment 315794 [details]
Patch
Comment 3 Jeremy Jones 2017-07-18 11:37:09 PDT
Comment on attachment 315794 [details]
Patch

LGTM
Comment 4 Jeremy Jones 2017-07-18 11:44:25 PDT
Comment on attachment 315794 [details]
Patch

provisional r+
Comment 5 Antoine Quint 2017-07-18 12:21:34 PDT
Created attachment 315814 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-07-18 12:59:17 PDT
Comment on attachment 315814 [details]
Patch for landing

Clearing flags on attachment: 315814

Committed r219621: <http://trac.webkit.org/changeset/219621>
Comment 7 WebKit Commit Bot 2017-07-18 12:59:18 PDT
All reviewed patches have been landed.  Closing bug.