https://www.w3.org/TR/webdriver/#screen-capture
Created attachment 318355 [details] Patch
hmm, it doesn't apply because it depends on patch attached to bug #175665. Maybe I can merge both patches/bugs since I ended up rewriting the takeScreenshot method.
Comment on attachment 318355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318355&action=review r=me Please re-run through EWS. > Source/WebKit/ChangeLog:16 > + checkjed and passed to the web process. Nit: checked > Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:691 > RefPtr<WebImage> image = page->scaledSnapshotWithOptions(snapshotRect, 1, SnapshotOptionsShareable); We received a bug the other day that the scale factor should be inherited from the device. Right now, retina screenshots are at @1x and look blurry. But that's a separate bug.
Created attachment 319175 [details] Patch for landing
Created attachment 319176 [details] Patch for landing
Attachment 319176 [details] did not pass style-queue: ERROR: Source/WebDriver/Session.h:116: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1514: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1531: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:2000: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r221255: <http://trac.webkit.org/changeset/221255>
<rdar://problem/34109485>