Bug 174614 - WebDriver: implement user prompt commands
Summary: WebDriver: implement user prompt commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: gtk-webdriver 175184
  Show dependency tree / graph
 
Reported: 2017-07-18 00:29 PDT by Carlos Garcia Campos
Modified: 2017-08-07 23:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.98 KB, patch)
2017-08-07 02:54 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-07-18 00:29:57 PDT 
https://www.w3.org/TR/webdriver/#user-prompts
Comment 1 Carlos Garcia Campos 2017-08-07 02:54:53 PDT 
Created attachment 317406 [details]
Patch
Comment 2 Build Bot 2017-08-07 02:56:41 PDT 
Attachment 317406 [details] did not pass style-queue:


ERROR: Source/WebDriver/Session.h:97:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:99:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.h:100:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:1236:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:1253:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:1270:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:1287:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.h:105:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.h:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.h:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:1466:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:1484:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:1502:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:1525:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 16 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Blaze Burg 2017-08-07 10:03:48 PDT 
Comment on attachment 317406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317406&action=review

r=me

> Source/WebDriver/Session.cpp:1525
> +void Session::sendAlertText(const String& text, Function<void (CommandResult&&)>&& completionHandler)

Nit: 'setAlertText' would match 'getAlertText'
Comment 4 Carlos Garcia Campos 2017-08-07 10:06:19 PDT 
(In reply to Brian Burg from comment #3)
> Comment on attachment 317406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317406&action=review
> 
> r=me

Thanks!

> > Source/WebDriver/Session.cpp:1525
> > +void Session::sendAlertText(const String& text, Function<void (CommandResult&&)>&& completionHandler)
> 
> Nit: 'setAlertText' would match 'getAlertText'

I agree, but I'm using the spec names in all other commands. . .
Comment 5 Carlos Garcia Campos 2017-08-07 23:22:13 PDT 
Committed r220386: <http://trac.webkit.org/changeset/220386>
Comment 6 Radar WebKit Bug Importer 2017-08-07 23:23:23 PDT 
<rdar://problem/33770045>