Bug 174610 – Update layout test fast/forms/content-with-margins-inside-button.html to work when button has a default color

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Layout test fast/forms/content-with-margins-inside-button.html is failing for GTK since, most likely, r217674 ("[GTK] Bump GTK+ and its dependencies in jhbuild"). However it cannot be simply rebaselined since it is a reftest. The text color inside the button no longer matches. Updating expectations accordingly.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 316838 [details]
Patch

[Darin Adler]

I don’t wish to be pedantic, but I believe that a bug like this one should not have the [GTK] prefix. We try to use those prefixes for changes that are truly specific to a particular port, changes that can’t possibly affect other ports, as opposed to patches that are motivated by a problem that shows only on one port, but are changes to cross-platform code.

[WebKit Commit Bot]

Comment on attachment 316838 [details]
Patch

Clearing flags on attachment: 316838

Committed r220104: <http://trac.webkit.org/changeset/220104>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Darin Adler from comment #2)
> I don’t wish to be pedantic, but I believe that a bug like this one should
> not have the [GTK] prefix. We try to use those prefixes for changes that are
> truly specific to a particular port, changes that can’t possibly affect
> other ports, as opposed to patches that are motivated by a problem that
> shows only on one port, but are changes to cross-platform code.

Agreed; changed the summary to match what I did.