Bug 174607 – Deprecate WebIconDatabase in WebKitLegacy/mac

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

Deprecate WebIconDatabase in WebKitLegacy

It already doesn't do anything. People using it should get the deprecation warnings, and we can prune the class down to its bare minimum interface.

[Brady Eidson]

Created attachment 315764 [details]
Patch

[Build Bot]

Attachment 315764 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:139:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Source/WebKitLegacy/win/WebView.cpp:3226:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 315771 [details]
Patch

[Build Bot]

Attachment 315771 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:139:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 315900 [details]
Patch

[Build Bot]

Attachment 315900 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:139:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 315986 [details]
Patch

[Build Bot]

Attachment 315986 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 315986 [details]
Patch

Attachment 315986 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4155687

New failing tests:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html

[Build Bot]

Created attachment 315990 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Brady Eidson]

(In reply to Build Bot from comment #9)
> Comment on attachment 315986 [details]
> Patch
> 
> Attachment 315986 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/4155687
> 
> New failing tests:
> media/modern-media-controls/scrubber-support/scrubber-support-drag.html

This failure is not due to this patch.

[WebKit Commit Bot]

Comment on attachment 315986 [details]
Patch

Clearing flags on attachment: 315986

Committed r219695: <http://trac.webkit.org/changeset/219695>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.