Bug 174607 - Deprecate WebIconDatabase in WebKitLegacy/mac
Summary: Deprecate WebIconDatabase in WebKitLegacy/mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-17 20:47 PDT by Brady Eidson
Modified: 2017-07-20 11:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (74.27 KB, patch)
2017-07-17 21:15 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (87.09 KB, patch)
2017-07-17 23:35 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (54.09 KB, patch)
2017-07-18 22:55 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (54.96 KB, patch)
2017-07-20 07:23 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.78 MB, application/zip)
2017-07-20 08:47 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-07-17 20:47:19 PDT
Deprecate WebIconDatabase in WebKitLegacy

It already doesn't do anything. People using it should get the deprecation warnings, and we can prune the class down to its bare minimum interface.
Comment 1 Brady Eidson 2017-07-17 21:15:20 PDT
Created attachment 315764 [details]
Patch
Comment 2 Build Bot 2017-07-17 21:18:19 PDT
Attachment 315764 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:139:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Source/WebKitLegacy/win/WebView.cpp:3226:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2017-07-17 23:35:05 PDT
Created attachment 315771 [details]
Patch
Comment 4 Build Bot 2017-07-17 23:38:02 PDT
Attachment 315771 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:139:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2017-07-18 22:55:48 PDT
Created attachment 315900 [details]
Patch
Comment 6 Build Bot 2017-07-18 22:58:28 PDT
Attachment 315900 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:139:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Brady Eidson 2017-07-20 07:23:16 PDT
Created attachment 315986 [details]
Patch
Comment 8 Build Bot 2017-07-20 07:25:31 PDT
Attachment 315986 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:31:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Build Bot 2017-07-20 08:47:26 PDT
Comment on attachment 315986 [details]
Patch

Attachment 315986 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4155687

New failing tests:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html
Comment 10 Build Bot 2017-07-20 08:47:27 PDT
Created attachment 315990 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Brady Eidson 2017-07-20 09:25:53 PDT
(In reply to Build Bot from comment #9)
> Comment on attachment 315986 [details]
> Patch
> 
> Attachment 315986 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/4155687
> 
> New failing tests:
> media/modern-media-controls/scrubber-support/scrubber-support-drag.html

This failure is not due to this patch.
Comment 12 WebKit Commit Bot 2017-07-20 11:07:34 PDT
Comment on attachment 315986 [details]
Patch

Clearing flags on attachment: 315986

Committed r219695: <http://trac.webkit.org/changeset/219695>
Comment 13 WebKit Commit Bot 2017-07-20 11:07:35 PDT
All reviewed patches have been landed.  Closing bug.