Bug 174601 – [JSC] There should be a debug option to dump a compiled RegExp Pattern

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

To aid in debugging, it makes sense to add a JSC option to dump RegExp Patterns.  This is effectively the intermediate form before the pattern is consumed by the YARR interpreter or JIT.  This would be similar to the DFG, FTL, AIR & B3 IR dumping options.

[Michael Saboff]

Created attachment 315736 [details]
Patch

[Michael Saboff]

I replaced the "U_FALLTHROUGH" that Xcode recommended with "FALLTHROUGH" in my local tree.  That should fix the "jsc" build.

[Michael Saboff]

Created attachment 315747 [details]
Updated patch - replaced U_FALLTHROUGH with FALLTHROUGH

[Alex Christensen]

Comment on attachment 315747 [details]
Updated patch - replaced U_FALLTHROUGH with FALLTHROUGH

View in context: https://bugs.webkit.org/attachment.cgi?id=315747&action=review

> Source/JavaScriptCore/runtime/Options.h:435
> +    v(bool, dumpCompiledRegExpPatterns, false, Normal, nullptr) \

Would it be useful to make this an option, not a compile time flag?  Could you use NDEBUG instead?

> Source/JavaScriptCore/yarr/YarrPattern.cpp:1004
> +

extra whitespace

[Saam Barati]

Comment on attachment 315747 [details]
Updated patch - replaced U_FALLTHROUGH with FALLTHROUGH

View in context: https://bugs.webkit.org/attachment.cgi?id=315747&action=review

>> Source/JavaScriptCore/runtime/Options.h:435
>> +    v(bool, dumpCompiledRegExpPatterns, false, Normal, nullptr) \
> 
> Would it be useful to make this an option, not a compile time flag?  Could you use NDEBUG instead?

Not sure I follow — these are runtime options. We tend to never turn on options that print things by default in any build style.

[Michael Saboff]

Committed r219611: <http://trac.webkit.org/changeset/219611>