Bug 174600 - [cmake] Set library types before their targets are created
Summary: [cmake] Set library types before their targets are created
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-17 16:54 PDT by Konstantin Tokarev
Modified: 2017-07-17 22:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.07 KB, patch)
2017-07-17 16:58 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (8.06 KB, patch)
2017-07-17 17:31 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-07-17 16:54:04 PDT 
Since r219560 library targets are created before PlatformXXX.cmake files are processed, however library type must be passed in add_library() call and cannot be changed afterwards. Set these variables in OptionsXXX.cmake.
Comment 1 Konstantin Tokarev 2017-07-17 16:58:45 PDT 
Created attachment 315731 [details]
Patch
Comment 2 Konstantin Tokarev 2017-07-17 17:31:59 PDT 
Created attachment 315738 [details]
Patch
Comment 3 WebKit Commit Bot 2017-07-17 22:46:59 PDT 
Comment on attachment 315738 [details]
Patch

Clearing flags on attachment: 315738

Committed r219602: <http://trac.webkit.org/changeset/219602>
Comment 4 WebKit Commit Bot 2017-07-17 22:47:00 PDT 
All reviewed patches have been landed.  Closing bug.