WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 174600
[cmake] Set library types before their targets are created
https://bugs.webkit.org/show_bug.cgi?id=174600
Summary
[cmake] Set library types before their targets are created
Konstantin Tokarev
Reported
2017-07-17 16:54:04 PDT
Since
r219560
library targets are created before PlatformXXX.cmake files are processed, however library type must be passed in add_library() call and cannot be changed afterwards. Set these variables in OptionsXXX.cmake.
Attachments
Patch
(8.07 KB, patch)
2017-07-17 16:58 PDT
,
Konstantin Tokarev
no flags
Details
Formatted Diff
Diff
Patch
(8.06 KB, patch)
2017-07-17 17:31 PDT
,
Konstantin Tokarev
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1
2017-07-17 16:58:45 PDT
Created
attachment 315731
[details]
Patch
Konstantin Tokarev
Comment 2
2017-07-17 17:31:59 PDT
Created
attachment 315738
[details]
Patch
WebKit Commit Bot
Comment 3
2017-07-17 22:46:59 PDT
Comment on
attachment 315738
[details]
Patch Clearing flags on attachment: 315738 Committed
r219602
: <
http://trac.webkit.org/changeset/219602
>
WebKit Commit Bot
Comment 4
2017-07-17 22:47:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug