Bug 174597 - DOMException should have its properties on the prototype
Summary: DOMException should have its properties on the prototype
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 174216
  Show dependency tree / graph
 
Reported: 2017-07-17 16:42 PDT by Chris Dumez
Modified: 2017-07-18 09:34 PDT (History)
10 users (show)

See Also:

Attachments
WIP Patch (665 bytes, patch)
2017-07-17 16:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.04 MB, application/zip)
2017-07-17 17:48 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.13 MB, application/zip)
2017-07-17 17:53 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.05 MB, application/zip)
2017-07-17 18:03 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.81 MB, application/zip)
2017-07-17 18:07 PDT, Build Bot 		no flags Details
Patch (23.58 KB, patch)
2017-07-17 21:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-07-17 16:42:49 PDT 
DOMException should have its properties on the prototype.
Comment 1 Chris Dumez 2017-07-17 16:44:00 PDT 
Created attachment 315727 [details]
WIP Patch
Comment 2 Build Bot 2017-07-17 16:48:06 PDT 
Comment on attachment 315727 [details]
WIP Patch

Attachment 315727 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/4138115

New failing tests:
(JS) JSTestException.cpp
(JS) JSTestException.h
Comment 3 Build Bot 2017-07-17 17:48:37 PDT 
Comment on attachment 315727 [details]
WIP Patch

Attachment 315727 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4138355

New failing tests:
inspector/debugger/setPauseOnExceptions-none.html
inspector/debugger/setPauseOnExceptions-uncaught.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.worker.html
inspector/debugger/setPauseOnExceptions-all.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor.html
Comment 4 Build Bot 2017-07-17 17:48:38 PDT 
Created attachment 315739 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-07-17 17:53:02 PDT 
Comment on attachment 315727 [details]
WIP Patch

Attachment 315727 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4138363

New failing tests:
inspector/debugger/setPauseOnExceptions-none.html
inspector/debugger/setPauseOnExceptions-uncaught.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.worker.html
inspector/debugger/setPauseOnExceptions-all.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor.html
Comment 6 Build Bot 2017-07-17 17:53:03 PDT 
Created attachment 315740 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-07-17 18:03:46 PDT 
Comment on attachment 315727 [details]
WIP Patch

Attachment 315727 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4138289

New failing tests:
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.worker.html
Comment 8 Build Bot 2017-07-17 18:03:48 PDT 
Created attachment 315741 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 9 Build Bot 2017-07-17 18:07:00 PDT 
Comment on attachment 315727 [details]
WIP Patch

Attachment 315727 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4138381

New failing tests:
inspector/debugger/setPauseOnExceptions-none.html
inspector/debugger/setPauseOnExceptions-uncaught.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.worker.html
inspector/debugger/setPauseOnExceptions-all.html
imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor.html
Comment 10 Build Bot 2017-07-17 18:07:02 PDT 
Created attachment 315742 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Chris Dumez 2017-07-17 21:34:12 PDT 
Created attachment 315765 [details]
Patch
Comment 12 WebKit Commit Bot 2017-07-18 00:33:39 PDT 
Comment on attachment 315765 [details]
Patch

Clearing flags on attachment: 315765

Committed r219607: <http://trac.webkit.org/changeset/219607>
Comment 13 WebKit Commit Bot 2017-07-18 00:33:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 Matt Lewis 2017-07-18 09:34:08 PDT 
This revision caused inspector/model/remote-object.html to fail consistently.
Talked with Chris and looks like a rebaseline is needed. Will be double-checking with Joe Pecoraro.

Rebaselined in:

https://trac.webkit.org/changeset/219612/webkit