Bug 174591 – Layout Test media/video-add-autoplay-user-gesture.html is flaky.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Matt Lewis]

media/video-add-autoplay-user-gesture.html is a flaky failure on macOS Sierra Release WK2.

It looks to have been flaky since being added.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-add-autoplay-user-gesture.html

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r219562%20(2990)/results.html


Diff:
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-add-autoplay-user-gesture-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-add-autoplay-user-gesture-actual.txt
@@ -3,6 +3,6 @@
 RUN(video.src = findMediaFile("video", "content/test"))
 RUN(video.setAttribute("autoplay", ""))
 RUN(document.body.appendChild(video))
-EVENT(playing)
+FAIL: did not end fast enough
 END OF TEST

[Jer Noble]

Looks like we should just remove the "failTestIn(1000)" call and allow the test to take the full timeout value (20s) before failing.

[Ryan Haddad]

I can easily reproduce this failure on Mojave with:
run-webkit-tests media/video-add-autoplay-user-gesture.html -fg --iter 25

[Ryan Haddad]

Created attachment 346170 [details]
Patch

[Ryan Haddad]

With the attached patch, the test passes 100/100 times.

[WebKit Commit Bot]

Comment on attachment 346170 [details]
Patch

Clearing flags on attachment: 346170

Committed r234428: <https://trac.webkit.org/changeset/234428>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42775727>