Bug 17458 - Bug in 3d-cube SunSpider test
Summary: Bug in 3d-cube SunSpider test
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-20 13:42 PST by John Resig
Modified: 2011-07-02 12:40 PDT (History)
5 users (show)

See Also:


Attachments
3d-cube.js patch (464 bytes, patch)
2008-02-20 13:43 PST, John Resig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Resig 2008-02-20 13:42:49 PST
There's a minor bug in the test which allows variables to leak into the global scope. Please see the attached patch.
Comment 1 John Resig 2008-02-20 13:43:31 PST
Created attachment 19238 [details]
3d-cube.js patch
Comment 2 Alexey Proskuryakov 2008-02-21 22:24:12 PST
Comment on attachment 19238 [details]
3d-cube.js patch

I assume this was meant for review; marking as such.
Comment 3 Darin Adler 2008-03-02 18:43:56 PST
Comment on attachment 19238 [details]
3d-cube.js patch

This change looks right to me. But Maciej should really be the one to review it.
Comment 4 Eric Seidel (no email) 2008-12-01 12:28:15 PST
Comment on attachment 19238 [details]
3d-cube.js patch

This bug doesn't need to sit in the review queue.  Maciej knows of the issue.  Sitting in the review queue for the next 10 months isn't going to solve the issue. :)  Maciej has noted reviewing this patch is blocked on other issues with sunspider distribution.
Comment 5 Maciej Stachowiak 2010-02-28 14:24:00 PST
This bug doesn't seem to affect the correctness of the result. Saving for SunSpider 2.0.