Change to the standard: https://github.com/whatwg/html/pull/2777. Rendered: search for enumerable in https://html.spec.whatwg.org/multipage/browsers.html#cross-origin-objects. Change to tests: https://github.com/w3c/web-platform-tests/pull/6538. Note: this is a change that all browsers need to make.
Created attachment 315695 [details] WIP Patch Still failing one check on http://w3c-test.org/html/browsers/origin/cross-origin-objects/cross-origin-objects.html. Asking for clarification on upstream tests before I go further.
Comment on attachment 315695 [details] WIP Patch Attachment 315695 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4137209 New failing tests: http/tests/security/cross-origin-descriptors.html js/dom/getOwnPropertyDescriptor.html imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315703 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 315695 [details] WIP Patch Attachment 315695 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4137214 New failing tests: js/dom/getOwnPropertyDescriptor.html http/tests/security/cross-origin-descriptors.html imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315706 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 315695 [details] WIP Patch Attachment 315695 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4137225 New failing tests: js/dom/getOwnPropertyDescriptor.html http/tests/security/cross-origin-descriptors.html imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315707 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 315695 [details] WIP Patch Attachment 315695 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4137243 New failing tests: http/tests/security/cross-origin-descriptors.html js/dom/getOwnPropertyDescriptor.html imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315708 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 315803 [details] WIP Patch
Created attachment 315804 [details] Patch
Comment on attachment 315804 [details] Patch Attachment 315804 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4143052 New failing tests: http/tests/security/cross-frame-access-enumeration.html
Created attachment 315818 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 315823 [details] Patch
Chris, I think the symbol-named props should still be non-enumerable, per spec. The upstream wpt gets this wrong...
(In reply to Boris Zbarsky from comment #15) > Chris, I think the symbol-named props should still be non-enumerable, per > spec. The upstream wpt gets this wrong... Thanks for letting me know!
Created attachment 315860 [details] Patch
Comment on attachment 315860 [details] Patch Attachment 315860 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4144714 New failing tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315864 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 315860 [details] Patch Attachment 315860 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4144724 New failing tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315866 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 315860 [details] Patch Attachment 315860 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4144823 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315870 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 315860 [details] Patch Attachment 315860 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4144901 New failing tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315871 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 315887 [details] Patch
Comment on attachment 315887 [details] Patch Attachment 315887 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4145895 New failing tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315894 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 315887 [details] Patch Attachment 315887 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4145907 New failing tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315895 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 315887 [details] Patch Attachment 315887 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4145908 New failing tests: imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Created attachment 315899 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 315902 [details] Patch
Comment on attachment 315902 [details] Patch There is still some discussion on the spec. Let's wait a little bit for the dust to settle.
Created attachment 315931 [details] Patch
Comment on attachment 315931 [details] Patch Clearing flags on attachment: 315931 Committed r219659: <http://trac.webkit.org/changeset/219659>
All reviewed patches have been landed. Closing bug.