Bug 174576 - Make cross-origin properties enumerable
Summary: Make cross-origin properties enumerable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 179117
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-17 01:11 PDT by Anne van Kesteren
Modified: 2017-11-04 15:49 PDT (History)
9 users (show)

See Also:


Attachments
WIP Patch (7.92 KB, patch)
2017-07-17 12:39 PDT, Chris Dumez
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.06 MB, application/zip)
2017-07-17 13:37 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.09 MB, application/zip)
2017-07-17 13:43 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.91 MB, application/zip)
2017-07-17 13:58 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (13.36 MB, application/zip)
2017-07-17 14:06 PDT, Build Bot
no flags Details
WIP Patch (16.52 KB, patch)
2017-07-18 09:46 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (26.63 KB, patch)
2017-07-18 10:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (980.14 KB, application/zip)
2017-07-18 12:40 PDT, Build Bot
no flags Details
Patch (27.56 KB, patch)
2017-07-18 12:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (27.75 KB, patch)
2017-07-18 16:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.12 MB, application/zip)
2017-07-18 17:38 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.18 MB, application/zip)
2017-07-18 17:45 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.06 MB, application/zip)
2017-07-18 18:22 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.76 MB, application/zip)
2017-07-18 18:28 PDT, Build Bot
no flags Details
Patch (27.34 KB, patch)
2017-07-18 21:29 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.30 MB, application/zip)
2017-07-18 22:35 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.46 MB, application/zip)
2017-07-18 22:41 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (2.08 MB, application/zip)
2017-07-18 22:55 PDT, Build Bot
no flags Details
Patch (26.85 KB, patch)
2017-07-18 23:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (29.41 KB, patch)
2017-07-19 10:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2017-07-17 01:11:51 PDT
Change to the standard: https://github.com/whatwg/html/pull/2777. Rendered: search for enumerable in https://html.spec.whatwg.org/multipage/browsers.html#cross-origin-objects.

Change to tests: https://github.com/w3c/web-platform-tests/pull/6538.

Note: this is a change that all browsers need to make.
Comment 1 Chris Dumez 2017-07-17 12:39:25 PDT
Created attachment 315695 [details]
WIP Patch

Still failing one check on http://w3c-test.org/html/browsers/origin/cross-origin-objects/cross-origin-objects.html. Asking for clarification on upstream tests before I go further.
Comment 2 Build Bot 2017-07-17 13:37:15 PDT
Comment on attachment 315695 [details]
WIP Patch

Attachment 315695 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4137209

New failing tests:
http/tests/security/cross-origin-descriptors.html
js/dom/getOwnPropertyDescriptor.html
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 3 Build Bot 2017-07-17 13:37:16 PDT
Created attachment 315703 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-07-17 13:43:23 PDT
Comment on attachment 315695 [details]
WIP Patch

Attachment 315695 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4137214

New failing tests:
js/dom/getOwnPropertyDescriptor.html
http/tests/security/cross-origin-descriptors.html
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 5 Build Bot 2017-07-17 13:43:25 PDT
Created attachment 315706 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-07-17 13:58:19 PDT
Comment on attachment 315695 [details]
WIP Patch

Attachment 315695 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4137225

New failing tests:
js/dom/getOwnPropertyDescriptor.html
http/tests/security/cross-origin-descriptors.html
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 7 Build Bot 2017-07-17 13:58:21 PDT
Created attachment 315707 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-07-17 14:06:40 PDT
Comment on attachment 315695 [details]
WIP Patch

Attachment 315695 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4137243

New failing tests:
http/tests/security/cross-origin-descriptors.html
js/dom/getOwnPropertyDescriptor.html
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 9 Build Bot 2017-07-17 14:06:42 PDT
Created attachment 315708 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 10 Chris Dumez 2017-07-18 09:46:05 PDT
Created attachment 315803 [details]
WIP Patch
Comment 11 Chris Dumez 2017-07-18 10:24:55 PDT
Created attachment 315804 [details]
Patch
Comment 12 Build Bot 2017-07-18 12:40:14 PDT
Comment on attachment 315804 [details]
Patch

Attachment 315804 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4143052

New failing tests:
http/tests/security/cross-frame-access-enumeration.html
Comment 13 Build Bot 2017-07-18 12:40:16 PDT
Created attachment 315818 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Chris Dumez 2017-07-18 12:48:15 PDT
Created attachment 315823 [details]
Patch
Comment 15 Boris Zbarsky 2017-07-18 14:29:08 PDT
Chris, I think the symbol-named props should still be non-enumerable, per spec.  The upstream wpt gets this wrong...
Comment 16 Chris Dumez 2017-07-18 14:54:57 PDT
(In reply to Boris Zbarsky from comment #15)
> Chris, I think the symbol-named props should still be non-enumerable, per
> spec.  The upstream wpt gets this wrong...

Thanks for letting me know!
Comment 17 Chris Dumez 2017-07-18 16:52:14 PDT
Created attachment 315860 [details]
Patch
Comment 18 Build Bot 2017-07-18 17:38:56 PDT
Comment on attachment 315860 [details]
Patch

Attachment 315860 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4144714

New failing tests:
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 19 Build Bot 2017-07-18 17:38:58 PDT
Created attachment 315864 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 20 Build Bot 2017-07-18 17:45:55 PDT
Comment on attachment 315860 [details]
Patch

Attachment 315860 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4144724

New failing tests:
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 21 Build Bot 2017-07-18 17:45:57 PDT
Created attachment 315866 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 22 Build Bot 2017-07-18 18:22:40 PDT
Comment on attachment 315860 [details]
Patch

Attachment 315860 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4144823

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 23 Build Bot 2017-07-18 18:22:42 PDT
Created attachment 315870 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 24 Build Bot 2017-07-18 18:28:27 PDT
Comment on attachment 315860 [details]
Patch

Attachment 315860 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4144901

New failing tests:
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 25 Build Bot 2017-07-18 18:28:28 PDT
Created attachment 315871 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 26 Chris Dumez 2017-07-18 21:29:50 PDT
Created attachment 315887 [details]
Patch
Comment 27 Build Bot 2017-07-18 22:35:26 PDT
Comment on attachment 315887 [details]
Patch

Attachment 315887 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145895

New failing tests:
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 28 Build Bot 2017-07-18 22:35:28 PDT
Created attachment 315894 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 29 Build Bot 2017-07-18 22:41:54 PDT
Comment on attachment 315887 [details]
Patch

Attachment 315887 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4145907

New failing tests:
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 30 Build Bot 2017-07-18 22:41:55 PDT
Created attachment 315895 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 31 Build Bot 2017-07-18 22:55:18 PDT
Comment on attachment 315887 [details]
Patch

Attachment 315887 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145908

New failing tests:
imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Comment 32 Build Bot 2017-07-18 22:55:19 PDT
Created attachment 315899 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 33 Chris Dumez 2017-07-18 23:05:15 PDT
Created attachment 315902 [details]
Patch
Comment 34 Chris Dumez 2017-07-19 09:03:39 PDT
Comment on attachment 315902 [details]
Patch

There is still some discussion on the spec. Let's wait a little bit for the dust to settle.
Comment 35 Chris Dumez 2017-07-19 10:09:51 PDT
Created attachment 315931 [details]
Patch
Comment 36 WebKit Commit Bot 2017-07-19 11:16:24 PDT
Comment on attachment 315931 [details]
Patch

Clearing flags on attachment: 315931

Committed r219659: <http://trac.webkit.org/changeset/219659>
Comment 37 WebKit Commit Bot 2017-07-19 11:16:26 PDT
All reviewed patches have been landed.  Closing bug.