Bug 174572 - Remove unnecessary exceptions from storage code
Summary: Remove unnecessary exceptions from storage code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-16 15:08 PDT by Sam Weinig
Modified: 2017-07-31 11:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (21.14 KB, patch)
2017-07-16 15:09 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.50 MB, application/zip)
2017-07-16 16:00 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.13 MB, application/zip)
2017-07-16 16:16 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.86 MB, application/zip)
2017-07-16 16:35 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1.07 MB, application/zip)
2017-07-16 16:37 PDT, Build Bot 		no flags Details
Patch (23.07 KB, patch)
2017-07-21 15:39 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (22.06 KB, patch)
2017-07-30 19:58 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-07-16 15:08:20 PDT 
Remove unnecessary exceptions from storage code
Comment 1 Sam Weinig 2017-07-16 15:09:19 PDT 
Created attachment 315628 [details]
Patch
Comment 2 Build Bot 2017-07-16 16:00:48 PDT 
Comment on attachment 315628 [details]
Patch

Attachment 315628 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4132489

New failing tests:
fast/storage/storage-detached-iframe.html
Comment 3 Build Bot 2017-07-16 16:00:49 PDT 
Created attachment 315630 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-07-16 16:16:33 PDT 
Comment on attachment 315628 [details]
Patch

Attachment 315628 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4132518

New failing tests:
fast/storage/storage-detached-iframe.html
Comment 5 Build Bot 2017-07-16 16:16:34 PDT 
Created attachment 315632 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-07-16 16:35:33 PDT 
Comment on attachment 315628 [details]
Patch

Attachment 315628 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4132529

New failing tests:
fast/storage/storage-detached-iframe.html
Comment 7 Build Bot 2017-07-16 16:35:34 PDT 
Created attachment 315633 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-07-16 16:37:38 PDT 
Comment on attachment 315628 [details]
Patch

Attachment 315628 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4132536

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
fast/storage/storage-detached-iframe.html
Comment 9 Build Bot 2017-07-16 16:37:39 PDT 
Created attachment 315634 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 10 Sam Weinig 2017-07-21 15:39:56 PDT 
Created attachment 316130 [details]
Patch
Comment 11 Darin Adler 2017-07-21 21:41:11 PDT 
Comment on attachment 316130 [details]
Patch

Why is this patch marked obsolete? Something wrong with it?
Comment 12 Sam Weinig 2017-07-30 19:43:38 PDT 
(In reply to Darin Adler from comment #11)
> Comment on attachment 316130 [details]
> Patch
> 
> Why is this patch marked obsolete? Something wrong with it?

Quite late a response. It broke a test. Not sure why I forgot about it though. Updating patch now.
Comment 13 Sam Weinig 2017-07-30 19:58:29 PDT 
Created attachment 316754 [details]
Patch
Comment 14 Chris Dumez 2017-07-31 10:36:59 PDT 
Comment on attachment 316754 [details]
Patch

r=me
Comment 15 WebKit Commit Bot 2017-07-31 11:05:12 PDT 
Comment on attachment 316754 [details]
Patch

Clearing flags on attachment: 316754

Committed r220071: <http://trac.webkit.org/changeset/220071>
Comment 16 WebKit Commit Bot 2017-07-31 11:05:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 17 Radar WebKit Bug Importer 2017-07-31 11:05:50 PDT 
<rdar://problem/33629020>