Bug 174567 – Remove ancient immediate repaint hack in Element::setActive()

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Andreas Kling]

Element::setActive() has a crazy old hack that tries to force a paint, sleep a bit, and then force another paint.
It's been there since early WK1/KHTML days, and clearly doesn't work in the new WK2 world. Let's get rid of it.

[Andreas Kling]

Created attachment 315610 [details]
Proposed patch

[Build Bot]

Attachment 315610 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLAnchorElement.h:80:  The parameter name "active" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 315610 [details]
Proposed patch

Attachment 315610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4131399

New failing tests:
http/tests/canvas/canvas-tainted-after-draw-image.html

[Build Bot]

Created attachment 315613 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Wenson Hsieh]

Comment on attachment 315610 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315610&action=review

LGTM, as long as there are no WebKit1 clients who still depend on this codepath. We should make sure that this doesn't break media controls in the Messages transcript, or links/buttons in iBooks.

> Source/WebCore/html/HTMLAnchorElement.h:80
> +    void setActive(bool active = true) final;

Can we just make this bool = true while we're at it?

[Brent Fulgham]

Pull request: https://github.com/WebKit/WebKit/pull/2968

[Brent Fulgham]

Pull request: https://github.com/Webkit/WebKit/pull/2968

[EWS]

Committed 253078@main (febc2b35e816): <https://commits.webkit.org/253078@main>

Reviewed commits have been landed. Closing PR #2968 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/98058542>