:active pseudo-class matches after mouse button has been released

[Antoine Quint]

Created attachment 315604 [details]
Testcase

See the attached testcase, click on the blue rectangle, and notice how remains red after you've clicked even though the :active pseudo-class should no longer be matching and the background-color should have reverted back to blue. Everything clears out if you move the mouse pointer or hit a key.

[Radar WebKit Bug Importer]

<rdar://problem/33340162>

[Antoine Quint]

This is the cause for https://bugs.webkit.org/show_bug.cgi?id=174563.

[Simon Fraser (smfr)]

Doesn't occur in an old build. Can you autospade it?

[Simon Fraser (smfr)]

Might be a system regression.

[Antoine Quint]

I haven't been able to autospade on Sierra, but Simon told me offline that a nightly build on Sierra didn't show the issue, so it's likely a regression in a framework WebKit depends on in High Sierra.

[Per Arne Vollan]

Created attachment 316028 [details]
Patch

[Per Arne Vollan]

(In reply to Per Arne Vollan from comment #6)
> Created attachment 316028 [details]
> Patch

I will add a test.

[Simon Fraser (smfr)]

Comment on attachment 316028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316028&action=review

I don't think we should land this yet.

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=174562

Need a radar here.

[Build Bot]

Comment on attachment 316028 [details]
Patch

Attachment 316028 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4158450

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

[Build Bot]

Created attachment 316057 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Darin Adler]

Comment on attachment 316028 [details]
Patch

Is there a way to do regression tests?

[Per Arne Vollan]

(In reply to Darin Adler from comment #11)
> Comment on attachment 316028 [details]
> Patch
> 
> Is there a way to do regression tests?

I have a work-in-progress test, but the following event sender calls seem to throw a JavaScript exception:

    eventSender.addTouchPoint(50, 50);
    eventSender.touchStart();

I will look further into this.

Thanks for reviewing, all!

Hi,

I'm a user and suffering from this bug.
I played a lot to try to find a workaround so there are some elements I found, hope that will help you :

- It does not happen inside iframes
- It only happens when the following trackpad option is set in the settings:
  - [x] force click and haptic feedback (settings -> trackpad -> first tab "point and click", in the bottom "force click")
- disabling force click in javascript (by preventing default of webkitmouseforcewillbegin) does not help ( https://developer.apple.com/library/content/documentation/AppleApplications/Conceptual/SafariJSProgTopics/RespondingtoForceTouchEventsfromJavaScript.html)

Thanks,

Configuration:
- safari 11.0.2
- macos 10.13.2
- macbook pro 15' 2017

[Antoine Quint]

This no longer occurs with STP 90, at least on macOS Catalina.