Bug 174555 - Implement FALLTHROUGH attribute for C with GCC
Summary: Implement FALLTHROUGH attribute for C with GCC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: PC All
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-15 20:01 PDT by Michael Catanzaro
Modified: 2017-07-23 14:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2017-07-15 20:15 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2017-07-23 07:49 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-07-15 20:01:16 PDT 
My attempt to silence the JSC -Wimplicit-fallthrough warnings in bug #174463 failed because they are coming from a C file, and our FALLTHROUGH macro is only implemented for C++. This is only possible to do for GCC, because Clang only supports this attribute using the [[C++ attribute syntax]].
Comment 1 Michael Catanzaro 2017-07-15 20:15:41 PDT 
Created attachment 315581 [details]
Patch
Comment 2 Michael Catanzaro 2017-07-23 07:49:28 PDT 
Created attachment 316228 [details]
Patch
Comment 3 WebKit Commit Bot 2017-07-23 14:01:31 PDT 
Comment on attachment 316228 [details]
Patch

Clearing flags on attachment: 316228

Committed r219791: <http://trac.webkit.org/changeset/219791>
Comment 4 WebKit Commit Bot 2017-07-23 14:01:33 PDT 
All reviewed patches have been landed.  Closing bug.