RESOLVED FIXED174542
[WinCairo] Provide timeout for WebSocket initial connection 
https://bugs.webkit.org/show_bug.cgi?id=174542
Summary [WinCairo] Provide timeout for WebSocket initial connection
Karlen Simonyan
Reported 2017-07-15 07:41:38 PDT
SocketStream hangs and indefinitely blocks rendering when WebSocket connection gets instantiated. Example web-site to check: GitHub (http://github.com). Requirement: user should be logged-in.
Attachments
Patch (1.30 KB, patch)
2017-07-15 08:10 PDT, Karlen Simonyan 		achristensen: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Karlen Simonyan
Comment 1 2017-07-15 08:10:12 PDT
Created attachment 315545 [details] Patch
Alex Christensen
Comment 2 2017-07-17 15:36:09 PDT
Comment on attachment 315545 [details] Patch Does this make it so every connection times out in 20ms? Shouldn't we make it so the main thread doesn't wait for a connection?
Alex Christensen
Comment 3 2017-07-18 00:07:13 PDT
Comment on attachment 315545 [details] Patch I think we should instead make it so the connection succeeding calls a callback, not waiting for the connection and not just setting a timeout of 20ms for the connection.
Karlen Simonyan
Comment 4 2017-07-18 11:22:56 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 315545 [details] > Patch > > Does this make it so every connection times out in 20ms? Shouldn't we make > it so the main thread doesn't wait for a connection? Vritually timeout setting affects only web-socket' handshake phase. I took value for 20ms to be aligned with SocketStreamHandleImplCurl.cpp#237
Alex Christensen
Comment 5 2017-07-18 11:43:42 PDT
That line is inside of a while loop that polls the socket for data. This line is not, which means that it will just fail once if the network isn't lightning fast.
Basuke Suzuki
Comment 6 2018-07-25 21:45:11 PDT
This bug was covered by https://bugs.webkit.org/show_bug.cgi?id=172630.
Note You need to log in before you can comment on or make changes to this bug.