Bug 174536 – line-height: <number> gets visually applied twice when text autosizing is in effect

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

line-height: <number> gets visually applied twice when text autosizing is in effect

[Myles C. Maxfield]

Created attachment 315530 [details]
Patch

[Build Bot]

Comment on attachment 315530 [details]
Patch

Attachment 315530 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4124119

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

[Build Bot]

Created attachment 315538 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Myles C. Maxfield]

Failure is unrelated.

[Simon Fraser (smfr)]

Comment on attachment 315530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315530&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=174536

You should probably make a radar for this too.

[Radar WebKit Bug Importer]

<rdar://problem/33338259>

[WebKit Commit Bot]

Comment on attachment 315530 [details]
Patch

Rejecting attachment 315530 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 315530, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:

Hunk #1 FAILED at 1440.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/css/StyleBuilderConverter.h.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/text-autosizing/line-height-number-expected.html
patching file LayoutTests/fast/text-autosizing/line-height-number.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4129110

[Myles C. Maxfield]

Committed r219543: <http://trac.webkit.org/changeset/219543>