Bug 174534 – Set LayoutTests' minimumLogicalFontSize to 0

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Myles C. Maxfield]

Set LayoutTests' minimumLogicalFontSize to 0

[Myles C. Maxfield]

Created attachment 315527 [details]
Patch

Comment on attachment 315527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315527&action=review

> Tools/ChangeLog:17
> +        https://bugs.webkit.org/show_bug.cgi?id=174406 is tracking work to make our
> +        various minimum font size settings also affect line-height. We should stop
> +        triggering these settings in our tests because that patch would cause a bunch
> +        of line heights to change in these tests. However, because these tests aren't
> +        actually about font sizes or line heights, this patch makes the tests insensitive
> +        to these settings.

9px is the default minimum logical font size. So are you implying that the change you are planning for bug 174406 will affect the line height in all apps that don’t set a non-default minimum logical font size?

[Build Bot]

Comment on attachment 315527 [details]
Patch

Attachment 315527 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4123599

New failing tests:
fast/ruby/ruby-simple.html
fast/ruby/rubyDOM-remove-text2.html
fast/ruby/nested-ruby.html
fast/css/bidi-override-in-anonymous-block.html
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
fast/backgrounds/background-position-parsing.html
fast/ruby/ruby-simple-rp.html
fast/ruby/ruby-empty-rt.html

[Build Bot]

Created attachment 315532 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Myles C. Maxfield]

Created attachment 315550 [details]
Patch

[Build Bot]

Comment on attachment 315550 [details]
Patch

Attachment 315550 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4126556

New failing tests:
http/tests/cookies/http-get-cookie-set-in-js.html

[Build Bot]

Created attachment 315560 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Myles C. Maxfield]

Failure is unrelated.

[Myles C. Maxfield]

(In reply to mitz from comment #2)
> Comment on attachment 315527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315527&action=review
> 
> > Tools/ChangeLog:17
> > +        https://bugs.webkit.org/show_bug.cgi?id=174406 is tracking work to make our
> > +        various minimum font size settings also affect line-height. We should stop
> > +        triggering these settings in our tests because that patch would cause a bunch
> > +        of line heights to change in these tests. However, because these tests aren't
> > +        actually about font sizes or line heights, this patch makes the tests insensitive
> > +        to these settings.
> 
> 9px is the default minimum logical font size. So are you implying that the
> change you are planning for bug 174406 will affect the line height in all
> apps that don’t set a non-default minimum logical font size?

Isn't that the whole point of the patch? To make minimumFontSize and minimumLogicalFontSize affect line-height?

[Myles C. Maxfield]

(In reply to Myles C. Maxfield from comment #9)
> (In reply to mitz from comment #2)
> > Comment on attachment 315527 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=315527&action=review
> > 
> > > Tools/ChangeLog:17
> > > +        https://bugs.webkit.org/show_bug.cgi?id=174406 is tracking work to make our
> > > +        various minimum font size settings also affect line-height. We should stop
> > > +        triggering these settings in our tests because that patch would cause a bunch
> > > +        of line heights to change in these tests. However, because these tests aren't
> > > +        actually about font sizes or line heights, this patch makes the tests insensitive
> > > +        to these settings.
> > 
> > 9px is the default minimum logical font size. So are you implying that the
> > change you are planning for bug 174406 will affect the line height in all
> > apps that don’t set a non-default minimum logical font size?
> 
> Isn't that the whole point of the patch? To make minimumFontSize and
> minimumLogicalFontSize affect line-height?

I guess the bug is about the accessibility font sizes, which set minimumFontSize but not minimumLogicalFontSize. This means I have to rethink my approach in https://bugs.webkit.org/show_bug.cgi?id=174406.

(My current approach was to treat the calculation of the computed font size as a black box, and simply query it's value and the value of the specified font-size, and then make line-height scale up accordingly. However, if I'm going to treat certain parts of the computation of the computed value of font-size differently from other parts of the computation, this approach isn't going to work.)

[Frédéric Wang (:fredw)]

Comment on attachment 315550 [details]
Patch

Removing review request since this is marked as WONTFIX