RESOLVED WONTFIX 174531
WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() may not be able to determine page that initiated navigation 
https://bugs.webkit.org/show_bug.cgi?id=174531
Summary WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() may not be ab...
Daniel Bates
Reported 2017-07-14 15:19:15 PDT
Currently WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() determines the originating page from the originating frame. So, if the originating frame is removed from the page then we cannot determine the originating page regardless of whether the originating page still exists (i.e. its windows was not closed). We should be able to determine the originating page so long as it still exists.
Attachments
Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2017-07-14 17:00:20 PDT
This seems like an OK improvement. But I'm not sure it's necessary. It's kind of difficult to maintain the plumbing, and test, to be able to identify the original WebView even after a frame has been removed from it. I don't know of a strong motivating example where original WebView is better than nil for navigations after the source frame has been removed from the WebView. Maybe nil is better for some cases? Given the difficulty involved, I think it may be better to stick with the existing nil behavior unless / until we come up with a motivating example for something more special.
Daniel Bates
Comment 2 2017-07-31 14:27:02 PDT
Removed a comment that referenced this bug in <http://trac.webkit.org/changeset/220074>.
Note You need to log in before you can comment on or make changes to this bug.