Add performance.mark()s around Speedometer test steps
Created attachment 315805 [details] Patch
Comment on attachment 315805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315805&action=review Thanks for the patch. > PerformanceTests/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=174530 This URL should appear right below the it title. > PerformanceTests/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). Followed by this line, and then the long description you have above. See other entries for the format. > PerformanceTests/Speedometer/resources/benchmark-runner.js:116 > + if (window.performance && window.performance.mark) { window.performance.mark(name); } Please put the call to mark in a separate line with an indentation but without curly braces to match the WebKit coding style. > PerformanceTests/Speedometer/resources/benchmark-runner.js:252 > + self._runTest(`${suite.name}.${test.name}`, suite, test.run, self._prepareReturnValue, function (syncTime, asyncTime) { I think itβs cleaner to pass in the test object, and construct the string in _runTrst function.
Created attachment 315838 [details] Patch
Comment on attachment 315838 [details] Patch Clearing flags on attachment: 315838 Committed r219640: <http://trac.webkit.org/changeset/219640>
All reviewed patches have been landed. Closing bug.