Bug 174530 - Add performance.mark()s around Speedometer test steps
Summary: Add performance.mark()s around Speedometer test steps
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2017-07-14 14:46 PDT by Matthew Kotsenas
Modified: 2017-07-18 16:22 PDT (History)
4 users (show)

See Also:

Patch (3.22 KB, patch)
2017-07-18 10:39 PDT, Matthew Kotsenas
no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2017-07-18 14:26 PDT, Matthew Kotsenas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Kotsenas 2017-07-14 14:46:57 PDT
Add performance.mark()s around Speedometer test steps
Comment 1 Matthew Kotsenas 2017-07-18 10:39:48 PDT
Created attachment 315805 [details]
Comment 2 Ryosuke Niwa 2017-07-18 11:42:08 PDT
Comment on attachment 315805 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=315805&action=review

Thanks for the patch.

> PerformanceTests/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=174530

This URL should appear right below the it title.

> PerformanceTests/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Followed by this line, and then the long description you have above.
See other entries for the format.

> PerformanceTests/Speedometer/resources/benchmark-runner.js:116
> +    if (window.performance && window.performance.mark) { window.performance.mark(name); }

Please put the call to mark in a separate line with an indentation but without curly braces to match the WebKit coding style.

> PerformanceTests/Speedometer/resources/benchmark-runner.js:252
> +        self._runTest(`${suite.name}.${test.name}`, suite, test.run, self._prepareReturnValue, function (syncTime, asyncTime) {

I think it’s cleaner to pass in the test object, and construct the string in _runTrst function.
Comment 3 Matthew Kotsenas 2017-07-18 14:26:01 PDT
Created attachment 315838 [details]
Comment 4 WebKit Commit Bot 2017-07-18 16:22:50 PDT
Comment on attachment 315838 [details]

Clearing flags on attachment: 315838

Committed r219640: <http://trac.webkit.org/changeset/219640>
Comment 5 WebKit Commit Bot 2017-07-18 16:22:51 PDT
All reviewed patches have been landed.  Closing bug.