Possible crash under NetworkSocketStream::didFailSocketStream(): Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x00007fffa1de73e2 IPC::Connection::sendMessage(std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::OptionSet<IPC::SendOption>) + 26 1 com.apple.WebKit 0x00007fffa1e2062f IPC::MessageSender::sendMessage(std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::OptionSet<IPC::SendOption>) + 57 2 com.apple.WebKit 0x00007fffa1e7cf2a bool IPC::MessageSender::send<Messages::WebSocketStream::DidFailSocketStream>(Messages::WebSocketStream::DidFailSocketStream const&, unsigned long long, WTF::OptionSet<IPC::SendOption>) + 112 3 com.apple.WebKit 0x00007fffa1e7ca31 non-virtual thunk to WebKit::NetworkSocketStream::didFailSocketStream(WebCore::SocketStreamHandle&, WebCore::SocketStreamError const&) + 51 4 com.apple.WebCore 0x00007fffa16cf679 WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl(WebCore::URL const&, WebCore::SocketStreamHandleClient&, WebCore::SessionID, WTF::String const&, WebCore::SourceApplicationAuditToken&&) + 793 5 com.apple.WebKit 0x00007fffa1e7c597 WebKit::NetworkSocketStream::create(WebCore::URL&&, WebCore::SessionID, WTF::String const&, unsigned long long, IPC::Connection&, WebCore::SourceApplicationAuditToken&&) + 147 6 com.apple.WebKit 0x00007fffa1e574bd WebKit::NetworkConnectionToWebProcess::createSocketStream(WebCore::URL&&, WebCore::SessionID, WTF::String, unsigned long long) + 107 7 com.apple.WebKit 0x00007fffa1e5cd65 void IPC::callMemberFunctionImpl<WebKit::NetworkConnectionToWebProcess, void (WebKit::NetworkConnectionToWebProcess::*)(WebCore::URL&&, WebCore::SessionID, WTF::String, unsigned long long), std::__1::tuple<WebCore::URL, WebCore::SessionID, WTF::String, unsigned long long>, 0ul, 1ul, 2ul, 3ul>(WebKit::NetworkConnectionToWebProcess*, void (WebKit::NetworkConnectionToWebProcess::*)(WebCore::URL&&, WebCore::SessionID, WTF::String, unsigned long long), std::__1::tuple<WebCore::URL, WebCore::SessionID, WTF::String, unsigned long long>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) + 63 8 com.apple.WebKit 0x00007fffa1e5b2fa void IPC::handleMessage<Messages::NetworkConnectionToWebProcess::CreateSocketStream, WebKit::NetworkConnectionToWebProcess, void (WebKit::NetworkConnectionToWebProcess::*)(WebCore::URL&&, WebCore::SessionID, WTF::String, unsigned long long)>(IPC::Decoder&, WebKit::NetworkConnectionToWebProcess*, void (WebKit::NetworkConnectionToWebProcess::*)(WebCore::URL&&, WebCore::SessionID, WTF::String, unsigned long long)) + 94 9 com.apple.WebKit 0x00007fffa1de69b5 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 119 10 com.apple.WebKit 0x00007fffa1de94ee IPC::Connection::dispatchOneMessage() + 176 11 com.apple.JavaScriptCore 0x00007fff96dcee39 WTF::RunLoop::performWork() + 169 12 com.apple.JavaScriptCore 0x00007fff96dcf0f2 WTF::RunLoop::performWork(void*) + 34 13 com.apple.CoreFoundation 0x00007fff93362c51 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 14 com.apple.CoreFoundation 0x00007fff93345a6f __CFRunLoopDoSources0 + 271 15 com.apple.CoreFoundation 0x00007fff9334501f __CFRunLoopRun + 1039 16 com.apple.CoreFoundation 0x00007fff93344999 CFRunLoopRunSpecific + 409 17 com.apple.Foundation 0x00007fff953e5306 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 18 com.apple.Foundation 0x00007fff953e51de -[NSRunLoop(NSRunLoop) run] + 76 19 libxpc.dylib 0x00007fffba9c5e2b _xpc_objc_main + 672 20 libxpc.dylib 0x00007fffba9c4a21 xpc_main + 417 21 com.apple.WebKit.Networking 0x10892a6a1 main + 490 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7604.1.28.2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:148) 22 libdyld.dylib 0x00007fffba6fa639 start + 1
<rdar://problem/32831441>
Created attachment 315481 [details] Patch
Comment on attachment 315481 [details] Patch Attachment 315481 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4121474 New failing tests: security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Created attachment 315487 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 315481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315481&action=review r=me > Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:92 > + }); Wow! Nice catch.
The 'mac' test failure doesn't seem likely to be related to this patch.
(In reply to Brent Fulgham from comment #6) > The 'mac' test failure doesn't seem likely to be related to this patch. Indeed, the test is currently failing on the non-EWS bots. The tree is red.
Comment on attachment 315481 [details] Patch Clearing flags on attachment: 315481 Committed r219525: <http://trac.webkit.org/changeset/219525>
All reviewed patches have been landed. Closing bug.
Comment on attachment 315481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315481&action=review >> Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:92 >> + }); > > Wow! Nice catch. Can m_client get zeroed out in between?
Comment on attachment 315481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315481&action=review >>> Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:92 >>> + }); >> >> Wow! Nice catch. > > Can m_client get zeroed out in between? m_client is a reference, not a pointer and cannot be zeroed out.