Bug 174513 - Make sure all CFHTTPCookieStorageRefs we create are scheduled
Summary: Make sure all CFHTTPCookieStorageRefs we create are scheduled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-14 11:01 PDT by Brady Eidson
Modified: 2017-07-15 23:57 PDT (History)
6 users (show)

See Also:


Attachments
Patch (20.79 KB, patch)
2017-07-14 11:06 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (19.99 KB, patch)
2017-07-14 11:26 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (23.33 KB, patch)
2017-07-15 18:12 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.07 MB, application/zip)
2017-07-15 20:22 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-07-14 11:01:51 PDT
Make sure all CFHTTPCookieStorageRefs we create are scheduled
Comment 1 Brady Eidson 2017-07-14 11:02:02 PDT
<rdar://problem/33221110>
Comment 2 Brady Eidson 2017-07-14 11:06:17 PDT
Created attachment 315454 [details]
Patch
Comment 3 Tim Horton 2017-07-14 11:18:50 PDT
Comment on attachment 315454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315454&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:9391
> -			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */;
> +			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */;

Don't think you want this.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:11170
> -		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */ = {
> +		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */ = {

Or this.
Comment 4 Brady Eidson 2017-07-14 11:24:42 PDT
(In reply to Tim Horton from comment #3)
> Comment on attachment 315454 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315454&action=review
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:9391
> > -			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */;
> > +			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */;
> 
> Don't think you want this.
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:11170
> > -		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */ = {
> > +		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */ = {
> 
> Or this.

I do, because it's The Future™, but as we discussed in person it can be in a separate patch.
Comment 5 Brady Eidson 2017-07-14 11:26:56 PDT
Created attachment 315463 [details]
Patch
Comment 6 WebKit Commit Bot 2017-07-14 12:16:13 PDT
The commit-queue encountered the following flaky tests while processing attachment 315463 [details]:

editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-07-14 12:16:44 PDT
Comment on attachment 315463 [details]
Patch

Clearing flags on attachment: 315463

Committed r219516: <http://trac.webkit.org/changeset/219516>
Comment 8 WebKit Commit Bot 2017-07-14 12:16:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Matt Lewis 2017-07-14 15:51:41 PDT
Reverted r219516 for reason:

This caused an API failure on macOS.

Committed r219529: <http://trac.webkit.org/changeset/219529>
Comment 11 Brady Eidson 2017-07-15 18:12:28 PDT
Created attachment 315576 [details]
Patch
Comment 12 Brady Eidson 2017-07-15 18:13:25 PDT
Letting EWS churn on this new patch and running API tests locally.

The Source changes are only one line different from the last one - Tim approved this.

Will CQ+ once bots and local API tests are happy
Comment 13 Build Bot 2017-07-15 20:22:18 PDT
Comment on attachment 315576 [details]
Patch

Attachment 315576 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4128339

New failing tests:
http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html
Comment 14 Build Bot 2017-07-15 20:22:19 PDT
Created attachment 315582 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 15 Brady Eidson 2017-07-15 20:28:57 PDT
(In reply to Build Bot from comment #14)
> Created attachment 315582 [details]
> Archive of layout-test-results from ews122 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

These are not because of this patch.
Comment 16 WebKit Commit Bot 2017-07-15 23:57:52 PDT
Comment on attachment 315576 [details]
Patch

Clearing flags on attachment: 315576

Committed r219545: <http://trac.webkit.org/changeset/219545>
Comment 17 WebKit Commit Bot 2017-07-15 23:57:54 PDT
All reviewed patches have been landed.  Closing bug.