Bug 174513 – Make sure all CFHTTPCookieStorageRefs we create are scheduled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Make sure all CFHTTPCookieStorageRefs we create are scheduled

[Brady Eidson]

<rdar://problem/33221110>

[Brady Eidson]

Created attachment 315454 [details]
Patch

[Tim Horton]

Comment on attachment 315454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315454&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:9391
> -			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */;
> +			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */;

Don't think you want this.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:11170
> -		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */ = {
> +		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */ = {

Or this.

[Brady Eidson]

(In reply to Tim Horton from comment #3)
> Comment on attachment 315454 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315454&action=review
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:9391
> > -			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */;
> > +			buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */;
> 
> Don't think you want this.
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:11170
> > -		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */ = {
> > +		1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */ = {
> 
> Or this.

I do, because it's The Future™, but as we discussed in person it can be in a separate patch.

[Brady Eidson]

Created attachment 315463 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 315463 [details]:

editing/spelling/spellcheck-async.html bug 160571 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 315463 [details]
Patch

Clearing flags on attachment: 315463

Committed r219516: <http://trac.webkit.org/changeset/219516>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This patch caused an API failure on all Macs.
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/2955/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/2955

[Matt Lewis]

Reverted r219516 for reason:

This caused an API failure on macOS.

Committed r219529: <http://trac.webkit.org/changeset/219529>

[Brady Eidson]

Created attachment 315576 [details]
Patch

[Brady Eidson]

Letting EWS churn on this new patch and running API tests locally.

The Source changes are only one line different from the last one - Tim approved this.

Will CQ+ once bots and local API tests are happy

[Build Bot]

Comment on attachment 315576 [details]
Patch

Attachment 315576 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4128339

New failing tests:
http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html

[Build Bot]

Created attachment 315582 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Brady Eidson]

(In reply to Build Bot from comment #14)
> Created attachment 315582 [details]
> Archive of layout-test-results from ews122 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

These are not because of this patch.

[WebKit Commit Bot]

Comment on attachment 315576 [details]
Patch

Clearing flags on attachment: 315576

Committed r219545: <http://trac.webkit.org/changeset/219545>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.