Bug 174509 - Rename RenderStyle::fontSize() to RenderStyle::computedFontPixelSize()
Summary: Rename RenderStyle::fontSize() to RenderStyle::computedFontPixelSize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-14 10:23 PDT by Myles C. Maxfield
Modified: 2017-07-15 23:11 PDT (History)
7 users (show)

See Also:


Attachments
Patch (18.48 KB, patch)
2017-07-14 10:27 PDT, Myles C. Maxfield
simon.fraser: review+
Details | Formatted Diff | Diff
Patch for committing (25.48 KB, patch)
2017-07-15 09:57 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch for committing (25.48 KB, patch)
2017-07-15 11:23 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.82 MB, application/zip)
2017-07-15 12:45 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (977.04 KB, application/zip)
2017-07-15 12:54 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-07-14 10:23:33 PDT
Rename RenderStyle::fontSize() to RenderStyle::computedFontPixelSize()
Comment 1 Myles C. Maxfield 2017-07-14 10:27:27 PDT
Created attachment 315441 [details]
Patch
Comment 2 Myles C. Maxfield 2017-07-15 09:57:41 PDT
Created attachment 315552 [details]
Patch for committing
Comment 3 Myles C. Maxfield 2017-07-15 11:23:29 PDT
Created attachment 315557 [details]
Patch for committing
Comment 4 Build Bot 2017-07-15 12:45:14 PDT
Comment on attachment 315557 [details]
Patch for committing

Attachment 315557 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4126711

New failing tests:
security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Comment 5 Build Bot 2017-07-15 12:45:15 PDT
Created attachment 315562 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-07-15 12:54:34 PDT
Comment on attachment 315557 [details]
Patch for committing

Attachment 315557 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4126721

New failing tests:
storage/websql/execute-sql-rowsAffected.html
http/tests/canvas/canvas-tainted-after-draw-image.html
Comment 7 Build Bot 2017-07-15 12:54:36 PDT
Created attachment 315563 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 8 Myles C. Maxfield 2017-07-15 22:39:30 PDT
Failures are unrelated.
Comment 9 WebKit Commit Bot 2017-07-15 23:08:44 PDT
Comment on attachment 315557 [details]
Patch for committing

Clearing flags on attachment: 315557

Committed r219544: <http://trac.webkit.org/changeset/219544>